Fix: getContent re-renders first content section if section's layout have matching names#25
Open
wildbeard wants to merge 5 commits into
Open
Fix: getContent re-renders first content section if section's layout have matching names#25wildbeard wants to merge 5 commits into
wildbeard wants to merge 5 commits into
Conversation
`getSection`, only the first's content is rendered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
When using
getSectionin from the mixin, if multiple sections with the same layout are passed the first section is rendered correctly but all subsequent sections are rendered with the first's content. Example:[ { "key": "aabbcc", "layout": "one-column-layout", "attributes": { "content": "<p>Content 1</p>" } }, { "key": "ccbbaa", "layout": "one-column-layout", "attributes": { "content": "<p>Content 2</p>" } } ]getSectionwould render<p>Content 1</p>in bothdivelements.The Fix
The fix is a backwards compatible workaround that will require any package users to update the way they use
getContentin the above scenario. The changes will allow any currant usage to remain intact without any changes to existing code.keytogetSectionso it can return early with a specific object rather ifkeyis provided. Otherwise functionality remains the same.getSectionContentthat simply returns the innerattributesproperty.resources/js/Pages/Default/Index.vueto usegetSectionContent