Repository navigation
Conversation
Rule 11: raw identifiers compare as the plain name; names unique to the code-region API are refused in every file; brace-wrapped, macro-passed, pub extern crate and re-exported platform-module forms are refused; the code submodules cannot be named. Rule 10: exactly one module-level fn enter, with the arguments to run and their bindings pinned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
atiernan
had a problem deploying
to
full-verification
November 22, 2026 15:19 — with
GitHub Actions
Error
The maintainer's decision E1 of 2026-11-16 adds one allowed shape of unsafe to rule 1: the single code entry in clazel-sys's enter.rs, which xtask rules 10 and 11 already enforce. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Added the CLAUDE.md rule 1 code-entry wording (abf156f), as the maintainer asked; this completes J.0(a)'s 'rule 1 gains the code-entry category in the same change as J.7'. A separate reviewer session checked it against jit.md E1, xtask rules 10 and 11, and enter.rs's SAFETY comments; its two corrections (Validated is only meant to be built by clazel-codecheck, since the checker bars only other crates from naming it; and the SAFETY comment cites the W^X man page and the ABI document, not a libc declaration) are in. 🤖 Generated with Claude Code |
…s it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two gaps the auditor found in the #277 checker rules. Only
xtaskchanges;crates/clazel-sysis untouched (hash stillf31e300b..., its audit step passes).Rule 11 (only
clazel-codecheckandclazel-jitreach the code-region API)Refused now, in every crate not on the allowlist:
r#clazel_sysis compared asclazel_syseverywhere (mention test, aliases, paths, type names).clazel-sys(CodeWriter,CodeRegion,SharedCode,CodeError,RemoteView,CODE_START,CONTEXT_BYTES,CONTEXT_WORDS,EXIT_CODE_WORD) in every file, whether or not it namesclazel_sys. A second file using the API through a re-export is judged.Validatedandenterstay judged only in files that nameclazel_sys: other crates legitimately have their own (Validatedin clazel-x509 and clazel-crypto,enterin clazel-layout andclazel_renderer::sandbox::enter), so flagging them everywhere would be a false positive. Closing every alias route (below) is what makes this sufficient.clazel_sysanywhere but the first segment of ausepath (use {clazel_sys::{self as s}},pub use {clazel_sys};),pub extern crate clazel_sys,use $cin a macro,clazel_syspassed to a macro as a bare name (m!(clazel_sys)).clazel_sysor an alias through acodemodule,macos::code/linux::code/windows::codeanywhere, and apubre-export of a platform module (macos,linux,windows), includingpub use ...::macos::{self as p}.Still allowed:
clazel_sys::macos::window::{self as sys}(clazel-window), and a private alias of a platform module (use clazel_sys::macos as os;, clazel-renderer). The alias is followed:os::code::xandos::enterare refused.Rule 10 (the single code-entry call)
In
crates/clazel-sys/src/enter.rs: exactly onefn enter, at module level (a second one in a nested module or animpl, or anenterthat is only a method, is refused). Its parameters are pinned toregion: &CodeRegion, entry: Validated, ctx: &mut Context. Its body must contain exactly the fourletstatements (offset,stub = region.base(),entry = stub.checked_add(offset).ok_or(..)?,rawfromctx) and no otherlet, loop,matchor closure that could rebind them. The single call ofrunmust have the argumentsstub, raw, entry, region.len(). The existing "runnamed only inenter, called once" check is kept.Tests
rule_11_refuses_the_evasions_found_in_the_277_audit: every evasion from the audit plus further variants (raw identifiers, macros, brace wrappers,pub extern crate, submodule aliases and re-exports, unique names in a file that never names the crate).rule_11_still_allows_the_legitimate_uses: clazel-window and clazel-renderer forms, macro uses ofclazel_sys::paths, other crates'enterandValidated.rule_10_pins_enter_and_its_arguments_to_run: a secondenterat module level, nested, or a method; noenter; other signature; other arguments torun; changed or extra bindings; loop, closure andmatcharound the call.entershaped like the real one.Results
cargo fmt: cleancargo clippy -p xtask --all-targets -- -D warnings: cleancargo test -p xtask: 148 passedcargo xtask check: STATIC CHECKS PASSED on the real tree,clazel-sys auditPASS, no false positivescargo xtask verify --changedwas not run; CI's full verification has not run on this PR, so it is not done by that standard. Nothing inclazel-syschanged, so no new audit row is needed.🤖 Generated with Claude Code