Skip to content

combining gps and reader code#51

Open
thebascos wants to merge 3 commits into
devfrom
hardware/combining-gps-and-reader
Open

combining gps and reader code#51
thebascos wants to merge 3 commits into
devfrom
hardware/combining-gps-and-reader

Conversation

@thebascos

Copy link
Copy Markdown
Contributor

Assigned GPS data to each RFID data

Checklist

First, create a draft pull request. Then mark the PR as ready for review when all necessary checkbox items has been completed

  • Reviewed own code
  • Commented on code that is hard to understand
  • Implemented tests for the feature/bugfix
  • All GitHub status checks pass
  • The frontend and backend PR previews have been deployed

Backend only

  • Generated the client api if there are new or deleted endpoints and/or DTOs

@thebascos thebascos requested a review from a team as a code owner May 8, 2023 11:26
@vercel

vercel Bot commented May 8, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
logistech ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 1:43pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
logistech-staging ⬜️ Ignored (Inspect) May 9, 2023 1:43pm

@vercel

vercel Bot commented May 8, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
logistech ✅ Ready (Inspect) Visit Preview May 8, 2023 11:26am
1 Ignored Deployment
Name Status Preview Updated (UTC)
logistech-staging ⬜️ Ignored (Inspect) May 8, 2023 11:26am

princhcanal
princhcanal previously approved these changes May 8, 2023
Comment on lines -11 to +9
#define WIEGAND_DATA_1 D4\
#define WIEGAND_DATA_1 D4

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@@ -141,47 +189,13 @@ void loop() {
Serial.println(new_code, HEX);
Serial.print("Total unique codes: ");
Serial.println(num_codes);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@princhcanal can you help figure out why every time this condition is met, the value of num_codes is a random number
image

@princhcanal princhcanal force-pushed the dev branch 15 times, most recently from 44eb6b6 to 629cf3d Compare May 24, 2023 15:00
@princhcanal princhcanal force-pushed the dev branch 2 times, most recently from 349106c to bc4df5b Compare May 29, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants