set up suppliers and manufactures to only have Bulk fielda and remove…

[thebascos]

… the bulk checkbox and column

set up suppliers and manufactures to only have Bulk fielda and remove the bulk checkbox and column

Provide a description on what was changed/added/fixed in this PR

Checklist

First, create a draft pull request. Then mark the PR as ready for review when all necessary checkbox items has been completed

• Reviewed own code
• Commented on code that is hard to understand
• Implemented tests for the feature/bugfix
• All GitHub status checks pass
• The frontend and backend PR previews have been deployed

Backend only

• Generated the client api if there are new or deleted endpoints and/or DTOs

[railway-app]

This PR was not deployed automatically as @thebascos does not have access to the Railway project.

In order to get automatic PR deploys, please add @thebascos to the project inside the project settings page.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
logistech	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 5, 2023 at 3:19PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
logistech-staging	⬜️ Ignored (Inspect)			Feb 5, 2023 at 3:19PM (UTC)

[princhcanal]

we can simplify this to just be

Suggested change

	const isSuppManu = () => {
	if (
	companyType === CompanyDTOTypeEnum.Supplier ||
	CompanyDTOTypeEnum.Manufacturer
	) {
	return true;
	} else {
	return false;
	}
	};
	const isSuppManu = () => {
	return companyType === CompanyDTOTypeEnum.Supplier || companyType === CompanyDTOTypeEnum.Manufacturer
	};

also, we can't just do:

companyType === CompanyDTOTypeEnum.Supplier || CompanyDTOTypeEnum.Manufacturer

like you had it because what that condition is saying is companyType === CompanyDTOTypeEnum.Supplier (which correctly checks if the company type is SUPPLIER) OR CompanyDTOTypeEnum.Manufacturer (which is just checking if this value is defined). instead, we need to do like in my suggestion above:

companyType === CompanyDTOTypeEnum.Supplier || companyType === CompanyDTOTypeEnum.Manufacturer

this way, we check if companyType === CompanyDTOTypeEnum.Supplier (which checks if company type is SUPPLIER) OR companyType === CompanyDTOTypeEnum.Manufacturer (which checks if company type is MANUFACTURER

[princhcanal]

also, since we reuse this logic, we can extract it to its own function. preferably, if you could extract this to its own custom hook, that would be great :). alternatively, you can also just extract it to a utility function and pass in the companyType as a parameter.