Skip to content

fix: AIFW-21696: ValidateMCPServersRequest allows omitting required fields#98

Merged
urajat merged 1 commit into
cisco-ai-defense:mainfrom
vokit-cisco:AIFW-21696-ValidateMCPServersRequest-allows-omitting-required-fields
Apr 10, 2026
Merged

fix: AIFW-21696: ValidateMCPServersRequest allows omitting required fields#98
urajat merged 1 commit into
cisco-ai-defense:mainfrom
vokit-cisco:AIFW-21696-ValidateMCPServersRequest-allows-omitting-required-fields

Conversation

@vokit-cisco

@vokit-cisco vokit-cisco commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes AIFW-21696 by enforcing required validation in MCP server validation request models.

This change makes missing validation inputs fail fast at model validation time, so incomplete payloads are rejected before request execution.

Changes

  • Made ValidateMCPServersRequest.urls required (changed from optional to required).
  • Made ValidateMCPServersRequest.transport_type required (changed from optional to required).
  • Updated ValidateMCPServersRequest field descriptions to reflect required transport type.
  • Added negative validation tests:
    • ValidateMCPServersRequest without urls raises ValidationError.
    • ValidateMCPServersRequest without transport_type raises ValidationError.
    • ValidateMCPServersRequest without both required fields raises ValidationError.

Test Plan

  • Targeted unit tests pass: pytest -q aidefense/tests/test_mcp_scan_base.py -k missing_required_fields.
  • Verified result: 3 passed, 84 deselected.
  • Validation path confirmed for missing urls.
  • Validation path confirmed for missing transport_type.
  • Validation path confirmed for payloads missing both required fields.

Compatibility Notes

  • Behavioral tightening: client code must now provide both urls and transport_type when building MCP server validation requests.
  • Expected impact: integrations that relied on omitted required fields will now fail validation and should be updated accordingly.

…ields

Signed-off-by: Volodymyr Kit <vokit@cisco.com>
@vokit-cisco vokit-cisco force-pushed the AIFW-21696-ValidateMCPServersRequest-allows-omitting-required-fields branch from f36aaed to 6680e36 Compare April 3, 2026 09:22
@vokit-cisco vokit-cisco changed the title fix: AIFW-19570: ValidateMCPServersRequest allows omitting required fields fix: AIFW-21696: ValidateMCPServersRequest allows omitting required fields Apr 3, 2026
@vokit-cisco vokit-cisco marked this pull request as ready for review April 6, 2026 07:42
@urajat urajat merged commit 3842d11 into cisco-ai-defense:main Apr 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants