Add support for primal domain regularization#26
Merged
Conversation
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Collaborator
Author
|
This looks good now. I will merge, as this mostly introduces new functionality (few possibilities for regressions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, we only support a few basic (mostly non-regularized) solvers, and the Primal-Dual Gybrid Gradient (PDHG) solver from Chambolle and Pock. The PDHG algorithm usually applies the regularization in the dual domain [1]. Other algorithms, like the Fast Iterative Shrinkage-Thresholding Algorithm (FISTA) from Beck and Teboulle apply the regularization in the primal domain [2]. The current code does not support them. In this PR, we want to introduce support for these algorithms and implement FISTA, as an example.
TODO
Notes
[1] A. Chambolle and T. Pock, “A First-Order Primal-Dual Algorithm for Convex Problems with Applications to Imaging,” J. Math. Imaging Vis., vol. 40, no. 1, pp. 120–145, Dec. 2010, doi: 10.1007/s10851-010-0251-1.
[2] A. Beck and M. Teboulle, “A Fast Iterative Shrinkage-Thresholding Algorithm for Linear Inverse Problems,” SIAM J. Imaging Sci., vol. 2, pp. 183–202, 2009, doi: 10.1137/080716542.