Skip to content

Add support for primal domain regularization#26

Merged
Obi-Wan merged 10 commits into
mainfrom
extend_solvers
Jun 25, 2026
Merged

Add support for primal domain regularization#26
Obi-Wan merged 10 commits into
mainfrom
extend_solvers

Conversation

@Obi-Wan

@Obi-Wan Obi-Wan commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Currently, we only support a few basic (mostly non-regularized) solvers, and the Primal-Dual Gybrid Gradient (PDHG) solver from Chambolle and Pock. The PDHG algorithm usually applies the regularization in the dual domain [1]. Other algorithms, like the Fast Iterative Shrinkage-Thresholding Algorithm (FISTA) from Beck and Teboulle apply the regularization in the primal domain [2]. The current code does not support them. In this PR, we want to introduce support for these algorithms and implement FISTA, as an example.

TODO

  • Implement new feature:
    • Implement primal domain proximal applications
    • Implement FISTA
  • Add or update unittests.
  • Add or update docstrings.
  • Update documentation.

Notes

[1] A. Chambolle and T. Pock, “A First-Order Primal-Dual Algorithm for Convex Problems with Applications to Imaging,” J. Math. Imaging Vis., vol. 40, no. 1, pp. 120–145, Dec. 2010, doi: 10.1007/s10851-010-0251-1.
[2] A. Beck and M. Teboulle, “A Fast Iterative Shrinkage-Thresholding Algorithm for Linear Inverse Problems,” SIAM J. Imaging Sci., vol. 2, pp. 183–202, 2009, doi: 10.1137/080716542.

@Obi-Wan Obi-Wan self-assigned this Jun 23, 2026
@Obi-Wan Obi-Wan added the enhancement New feature or request label Jun 23, 2026
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Obi-Wan added 9 commits June 25, 2026 14:08
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
@Obi-Wan Obi-Wan marked this pull request as ready for review June 25, 2026 15:30
@Obi-Wan Obi-Wan added this to the Release 3.0 milestone Jun 25, 2026
@Obi-Wan

Obi-Wan commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

This looks good now. I will merge, as this mostly introduces new functionality (few possibilities for regressions).

@Obi-Wan Obi-Wan merged commit 281e5af into main Jun 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant