fix: align managed agent shutdown timing - #40
Merged
Merged
Conversation
Member
Author
|
CI note: the source checks and all 23 tests pass. The job currently fails only at |
rung
force-pushed
the
agent/align-agent-shutdown-timeout
branch
from
August 8, 2026 18:15
a33b4aa to
e23a562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs cicd-sensor/cicd-sensor#143
Pairs with cicd-sensor/cicd-sensor#148.
Why
The Action-managed Agent unit used
TimeoutStopSec=5s, while the Agent needs a longer grace period to flush manager output during shutdown. systemd could therefore send SIGKILL before the Agent finished its own drain.The Action owns both the Agent command line and its transient systemd unit, so those deadlines should be configured together.
What
--shutdown-grace 20sto Action-managed AgentsTimeoutStopSecto30s5sdist/mainbundleVerification
npm run lintnpm testnpm run check-distevents_total: 9/10The remaining incomplete runtime tail shows that timeout alignment alone does not guarantee every streaming record under concurrent teardown. This PR fixes the Action's supervisor deadline mismatch; Agent-side project-result/finalization behavior remains owned by #148.