feat: add colorScheme option#411
Draft
AriPerkkio wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 431882a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
6fad466 to
29e1f0a
Compare
8d2a48f to
431882a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
colorSchemeoption #403What Changed
Adds
parameters.chromatic.colorScheme: 'light' | 'dark'. Value is resolved during runtime fromwindow.matchMediawhentakeSnapshot()is called - similarly as viewport is resolved during runtime. This allows a single test case to have multiple snapshot specificcolorSchemevalues.How to test
Added E2E tests that are all currently rendering with
'light', as Capture support forparameters.chromatic.colorSchemeis required.