Delay check of build-storybook script validation#1327
Open
jmhobbs wants to merge 2 commits into
Open
Conversation
Contributor
|
📦 Package Size: 7100 KB |
We need to have more information available for option validation before we announce the build. Slipped into the auth task because we do not want to inject another task for this.
Since this is specific to web Storybook builds, it is being moved out of getOptions and into storybookInfo. It is gated by ctx.isReactNativeApp which we get in the auth task in the previous commit.
jmhobbs
force-pushed
the
jmhobbs/cap-4395-delay-check-of-build-storybook-script-name
branch
from
c18f6c1 to
0229072
Compare
jmhobbs
added
release
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
+ Coverage 80.74% 80.87% +0.12%
==========================================
Files 214 214
Lines 4197 4214 +17
Branches 1197 1207 +10
==========================================
+ Hits 3389 3408 +19
+ Misses 694 692 -2
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-storybookscript requirement does not apply to React Native only projects, so we need to work around that. This adds a pre-flight request to get app details and see if it is a React Native app.The request was added to
authto avoid another task in the UI, and validation has moved fromgetOptionstostorybookInfoto delay it until the proper context is available, but still run it beforeannounceBuild📦 Published PR as canary version:
16.10.1--canary.1327.25700929811.1✨ Test out this PR locally via:
npm install chromatic@16.10.1--canary.1327.25700929811.1 # or yarn add chromatic@16.10.1--canary.1327.25700929811.1