Skip to content

fix(cli): honor finite takeover loops#30

Open
nike-beep wants to merge 2 commits into
chekusu:mainfrom
nike-beep:wanman/restore-takeover-loops-mode
Open

fix(cli): honor finite takeover loops#30
nike-beep wants to merge 2 commits into
chekusu:mainfrom
nike-beep:wanman/restore-takeover-loops-mode

Conversation

@nike-beep

Copy link
Copy Markdown

Changes

  • preserve explicit --loops N takeover runs instead of forcing infinite takeover mode
  • factor takeover run-option normalization into �uildTakeoverRunOptions so finite and default modes are testable
  • harden takeover command tests for Windows git invocation and path-separator handling

Verification

  • pnpm --filter @wanman/cli typecheck
  • pnpm --filter @wanman/cli exec vitest run src/commands/takeover.test.ts --coverage.enabled true --coverage.provider v8 --coverage.reporter text --coverage.include src/commands/takeover.ts

Test Coverage

  • akeover.ts: Statements 98.52% (67/68), Lines 98.48% (65/66), Functions 100% (6/6), Branches 77.08% (37/48)
  • upstream origin push returned 403 for
    ike-beep, so this PR is published from the configured fork remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants