Repository navigation
fix: 서비스 소개서 모바일 화면 개선 - #508
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe service introduction page updates its metadata and font, uses dynamic viewport sizing and centered slide positioning, adds a portrait-orientation notice, and resets slide positioning for print output. ChangesService introduction responsive presentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request enhances the mobile experience of the service introduction page by adding favicons, utilizing dynamic viewport height (100dvh), centering slides, and introducing a portrait-mode orientation notice that prompts users to rotate their device. The review feedback suggests removing an unused @font-face declaration to keep the stylesheet clean and adding a CSS rotation animation to the orientation phone icon to make the user instruction more intuitive.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @font-face { | ||
| font-family: "Checkmo Store Brands"; | ||
| src: url("assets/fonts/FontAwesome5_Brands.ttf") format("truetype"); | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| font-display: block; | ||
| } |
| .orientation-phone { | ||
| position: relative; | ||
| width: 50px; | ||
| height: 82px; | ||
| margin-bottom: 34px; | ||
| border: 4px solid var(--brand); | ||
| border-radius: 13px; | ||
| transform: rotate(90deg); | ||
| box-shadow: 0 10px 24px rgba(74, 57, 49, 0.14); | ||
| } |
There was a problem hiding this comment.
모바일 세로 화면에서 가로 회전을 안내하는 .orientation-phone 아이콘이 정적으로 90도 회전되어 있어, 사용자가 직관적으로 회전 동작을 인지하기 어려울 수 있습니다. 간단한 회전 애니메이션을 추가하면 사용자가 휴대폰을 가로로 돌려야 한다는 점을 훨씬 더 명확하고 직관적으로 이해할 수 있습니다.
| .orientation-phone { | |
| position: relative; | |
| width: 50px; | |
| height: 82px; | |
| margin-bottom: 34px; | |
| border: 4px solid var(--brand); | |
| border-radius: 13px; | |
| transform: rotate(90deg); | |
| box-shadow: 0 10px 24px rgba(74, 57, 49, 0.14); | |
| } | |
| .orientation-phone { | |
| position: relative; | |
| width: 50px; | |
| height: 82px; | |
| margin-bottom: 34px; | |
| border: 4px solid var(--brand); | |
| border-radius: 13px; | |
| transform: rotate(90deg); | |
| box-shadow: 0 10px 24px rgba(74, 57, 49, 0.14); | |
| animation: rotate-phone 2s ease-in-out infinite; | |
| } | |
| @keyframes rotate-phone { | |
| 0% { | |
| transform: rotate(0deg); | |
| } | |
| 40%, 100% { | |
| transform: rotate(90deg); | |
| } | |
| } |
📌 개요 (Summary)
🛠️ 변경 사항 (Changes)
📸 스크린샷 (Screenshots)
(UI 변경 사항이 있다면 첨부해주세요)
✅ 체크리스트 (Checklist)
pnpm build)pnpm lint)Summary by CodeRabbit
New Features
Bug Fixes