Repository navigation
fix: 7/20 QA 사항 개선 - #504
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdmin applicant and member pages add back and refresh controls. Comment mapping now preserves comments with missing authors, displays placeholders for deleted comments, and disables editing, reporting, replying, and profile actions for deleted comments. ChangesAdmin navigation and comment state
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- 모임 가입 신청 관리, 인원 관리에 뒤로가기, 새로고침 버튼 추가 및 통일
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds 'Go Back' and 'Refresh' buttons to the group admin applicant and member management pages, and implements UI handling for deleted comments and replies by masking author details and content while disabling associated actions. The review feedback suggests ensuring isValidUrl is only called when profileImageUrl is defined to prevent potential runtime or type errors, and verifying that storyAuthorNickname is defined before comparing it to prevent isAuthor from incorrectly evaluating to true when both are undefined.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| profileImgSrc: !c.deleted && isValidUrl(c.authorInfo?.profileImageUrl) | ||
| ? c.authorInfo?.profileImageUrl | ||
| : DEFAULT_PROFILE_IMAGE, |
There was a problem hiding this comment.
c.authorInfo?.profileImageUrl이 null 또는 undefined일 때 isValidUrl에 전달되면 런타임 에러가 발생하거나 타입 오류가 발생할 수 있습니다. 안전하게 타입을 좁히고 방어적 프로그래밍을 적용하기 위해, 값이 존재할 때만 isValidUrl을 호출하도록 개선하는 것이 좋습니다.
| profileImgSrc: !c.deleted && isValidUrl(c.authorInfo?.profileImageUrl) | |
| ? c.authorInfo?.profileImageUrl | |
| : DEFAULT_PROFILE_IMAGE, | |
| profileImgSrc: !c.deleted && c.authorInfo?.profileImageUrl && isValidUrl(c.authorInfo.profileImageUrl) | |
| ? c.authorInfo.profileImageUrl | |
| : DEFAULT_PROFILE_IMAGE, |
| createdAt: c.createdAt, | ||
| isAuthor: c.authorInfo.nickname === storyAuthorNickname, | ||
| isMine: c.writtenByMe, | ||
| isAuthor: !c.deleted && c.authorInfo?.nickname === storyAuthorNickname, |
There was a problem hiding this comment.
storyAuthorNickname과 c.authorInfo?.nickname이 모두 undefined인 경우, undefined === undefined가 true로 평가되어 작성자가 아님에도 isAuthor가 true로 잘못 설정될 수 있는 논리적 오류가 있습니다. storyAuthorNickname이 유효한 값인지 먼저 확인하는 조건을 추가해야 합니다.
| isAuthor: !c.deleted && c.authorInfo?.nickname === storyAuthorNickname, | |
| isAuthor: !c.deleted && !!storyAuthorNickname && c.authorInfo?.nickname === storyAuthorNickname, |
| profileImgSrc: !c.deleted && isValidUrl(c.authorInfo?.profileImageUrl) | ||
| ? c.authorInfo?.profileImageUrl as string | ||
| : DEFAULT_PROFILE_IMAGE, |
There was a problem hiding this comment.
c.authorInfo?.profileImageUrl이 null 또는 undefined일 때 isValidUrl에 전달되는 것을 방지하고, 불필요한 타입 단언(as string)을 제거하기 위해 값이 존재할 때만 isValidUrl을 호출하도록 타입을 안전하게 좁히는 것이 좋습니다.
| profileImgSrc: !c.deleted && isValidUrl(c.authorInfo?.profileImageUrl) | |
| ? c.authorInfo?.profileImageUrl as string | |
| : DEFAULT_PROFILE_IMAGE, | |
| profileImgSrc: !c.deleted && c.authorInfo?.profileImageUrl && isValidUrl(c.authorInfo.profileImageUrl) | |
| ? c.authorInfo.profileImageUrl | |
| : DEFAULT_PROFILE_IMAGE, |
| createdAt: c.createdAt, | ||
| isAuthor: c.authorInfo?.nickname === storyAuthorNickname, | ||
| isMine: c.writtenByMe, | ||
| isAuthor: !c.deleted && c.authorInfo?.nickname === storyAuthorNickname, |
There was a problem hiding this comment.
storyAuthorNickname과 c.authorInfo?.nickname이 모두 undefined일 때 isAuthor가 true로 잘못 평가되는 버그를 방지하기 위해, storyAuthorNickname이 유효한 값인지 검증하는 조건을 추가하는 것이 안전합니다.
| isAuthor: !c.deleted && c.authorInfo?.nickname === storyAuthorNickname, | |
| isAuthor: !c.deleted && !!storyAuthorNickname && c.authorInfo?.nickname === storyAuthorNickname, |
|
|
📌 개요 (Summary)
🛠️ 변경 사항 (Changes)
📸 스크린샷 (Screenshots)
(UI 변경 사항이 있다면 첨부해주세요)
✅ 체크리스트 (Checklist)
pnpm build)pnpm lint)Summary by CodeRabbit
New Features
Bug Fixes