Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: cursor-pointer 추가
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds cursor styling classes to interactive elements throughout the application. Buttons and clickable elements receive ChangesCursor Styling Consistency
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the user experience by adding cursor-pointer and disabled:cursor-not-allowed classes to interactive elements and buttons across multiple components. The review feedback suggests using the enabled: prefix for hover utility classes to prevent visual feedback on disabled buttons, ensuring a more consistent and polished interface.
|
|
||
| const buttonStyle = | ||
| "flex h-[48px] items-center justify-center gap-[10px] rounded-[8px] bg-Gray-1 px-[16px] py-[12px] w-[120px] md:w-[200px] disabled:opacity-50 disabled:cursor-not-allowed transition-colors hover:bg-Gray-2"; | ||
| "flex h-[48px] items-center justify-center gap-[10px] rounded-[8px] bg-Gray-1 px-[16px] py-[12px] w-[120px] md:w-[200px] disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed transition-colors hover:bg-Gray-2"; |
Contributor
There was a problem hiding this comment.
The hover:bg-Gray-2 utility will still apply the hover background color even when the button is disabled. To ensure the button remains visually consistent in its disabled state, use the enabled: modifier for hover effects.
Suggested change
| "flex h-[48px] items-center justify-center gap-[10px] rounded-[8px] bg-Gray-1 px-[16px] py-[12px] w-[120px] md:w-[200px] disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed transition-colors hover:bg-Gray-2"; | |
| "flex h-[48px] items-center justify-center gap-[10px] rounded-[8px] bg-Gray-1 px-[16px] py-[12px] w-[120px] md:w-[200px] disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed transition-colors enabled:hover:bg-Gray-2"; |
| onClick={onConfirm} | ||
| disabled={isPending} | ||
| className="h-[44px] rounded-[8px] bg-primary-2 text-White body_1_2 hover:brightness-95 disabled:opacity-50" | ||
| className="h-[44px] rounded-[8px] bg-primary-2 text-White body_1_2 hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" |
Contributor
There was a problem hiding this comment.
The hover:brightness-95 effect will trigger even when the button is disabled. It is better to use the enabled: modifier so that the brightness doesn't change when the button is in a pending or disabled state.
Suggested change
| className="h-[44px] rounded-[8px] bg-primary-2 text-White body_1_2 hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" | |
| className="h-[44px] rounded-[8px] bg-primary-2 text-White body_1_2 enabled:hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" |
| onClick={onClose} | ||
| disabled={isPending} | ||
| className="h-[44px] rounded-[8px] border border-Subbrown-4 bg-White text-Gray-7 body_1_2 hover:brightness-95 disabled:opacity-50" | ||
| className="h-[44px] rounded-[8px] border border-Subbrown-4 bg-White text-Gray-7 body_1_2 hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" |
Contributor
There was a problem hiding this comment.
Similar to the confirm button, the cancel button should only apply hover effects when it is not disabled.
Suggested change
| className="h-[44px] rounded-[8px] border border-Subbrown-4 bg-White text-Gray-7 body_1_2 hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" | |
| className="h-[44px] rounded-[8px] border border-Subbrown-4 bg-White text-Gray-7 body_1_2 enabled:hover:brightness-95 disabled:opacity-50 cursor-pointer disabled:cursor-not-allowed" |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/app/(main)/page.tsx (1)
1-85: Refactor duplicated home UI betweensrc/app/(main)/page.tsxandsrc/app/(main)/home/HomePageClient.tsx
- The diff shows the components are effectively the same (queries/handlers/JSX structure), with differences largely limited to the exported function name (
HomePage→HomePageClient) and some comment/whitespace changes.- Extract the shared implementation into a single component to avoid maintaining two parallel home pages.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/`(main)/page.tsx around lines 1 - 85, Duplicate home UI exists between HomePage and HomePageClient; extract the shared logic and JSX into a single reusable component (e.g., HomePageCore or HomeContent) and have both HomePage and HomePageClient render that core. Move shared hooks (useAuthStore, useRecommendedMembersQuery, useMyClubsQuery, useHomeInteractions) and derived vars (groups, recommendedUsers) into the core component or accept them as props if one wrapper must provide data differences, then reuse the same JSX that references HomeNewsSection, HomeClubSection, HomeRecommendationSection, and HomeStoryList; keep only minimal wrappers named HomePage and HomePageClient that call the core component to preserve existing exports. Ensure event handlers (handleToggleFollow, onProfileClick, onSubscribeClick) are forwarded unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/app/`(main)/page.tsx:
- Around line 1-85: Duplicate home UI exists between HomePage and
HomePageClient; extract the shared logic and JSX into a single reusable
component (e.g., HomePageCore or HomeContent) and have both HomePage and
HomePageClient render that core. Move shared hooks (useAuthStore,
useRecommendedMembersQuery, useMyClubsQuery, useHomeInteractions) and derived
vars (groups, recommendedUsers) into the core component or accept them as props
if one wrapper must provide data differences, then reuse the same JSX that
references HomeNewsSection, HomeClubSection, HomeRecommendationSection, and
HomeStoryList; keep only minimal wrappers named HomePage and HomePageClient that
call the core component to preserve existing exports. Ensure event handlers
(handleToggleFollow, onProfileClick, onSubscribeClick) are forwarded unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5e77771f-54d4-42ee-a422-b06f4eb714de
📒 Files selected for processing (32)
src/app/(main)/home/HomePageClient.tsxsrc/app/(main)/page.tsxsrc/app/(main)/setting/account-status/AccountStatusPageClient.tsxsrc/app/(main)/setting/email/EmailChangePageClient.tsxsrc/app/(main)/setting/password/PasswordChangePageClient.tsxsrc/app/(main)/setting/profile/ProfileEditPageClient.tsxsrc/app/(main)/setting/support/SupportPageClient.tsxsrc/components/base-ui/Bookcase/bookid/BookshelfDeleteConfirmModal.tsxsrc/components/base-ui/Bookcase/bookid/StarRating.tsxsrc/components/base-ui/Bookcase/bookid/TeamDebateSection.tsxsrc/components/base-ui/Comment/comment_edit_form.tsxsrc/components/base-ui/Group-Search/search_club_apply_modal.tsxsrc/components/base-ui/Group-Search/search_clublist/search_clublist_item.tsxsrc/components/base-ui/Join/JoinInput.tsxsrc/components/base-ui/Join/steps/EmailVerification/EmailVerification.tsxsrc/components/base-ui/Join/steps/ProfileImage/InterestCategorySelector.tsxsrc/components/base-ui/Join/steps/ProfileImage/ProfileImageUploader.tsxsrc/components/base-ui/MyPage/ProfileSection/MyPageTabs.tsxsrc/components/base-ui/Profile/Follow/FollowItem.tsxsrc/components/base-ui/Profile/OtherUser/OtherUserProfileTabs.tsxsrc/components/base-ui/Profile/OtherUser/ProfileUserInfo.tsxsrc/components/base-ui/Profile/items/LibraryCard.tsxsrc/components/base-ui/Profile/items/MeetingCard.tsxsrc/components/base-ui/Settings/Block/BlockedUserItem.tsxsrc/components/base-ui/Settings/EditProfile/ProfileImageSection.tsxsrc/components/base-ui/home/Subscription/list_subscribe_element.tsxsrc/components/base-ui/home/Subscription/list_subscribe_large.tsxsrc/components/common/ConfirmModal.tsxsrc/components/common/find-account/PrimaryButton.tsxsrc/components/common/modals/report-block/ActionSelectionModal.tsxsrc/components/common/modals/report-block/BlockConfirmModal.tsxsrc/components/layout/BookSelectModal.tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: 랜딩 페이지 타이틀 CheckMo → 책모 - 독서 모임 플랫폼 변경
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit