Repository navigation
feat: 책 이야기 수정 구현 - #284
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request implements the story editing feature, including a new edit page, navigation updates, and the necessary API and mutation hooks. The review feedback recommends renaming an ambiguously named state variable for better clarity and refactoring the query invalidation logic to ensure all relevant story data is refreshed upon a successful update.
|
@coderabbitai 해당 작업에 대해서 hugging face 와 같은 외부 모델 툴들을 사용해서 성능 및 보안 측면에서 더 디벨롭 할 수 있는 부분이 있을까? 있다면 알려주고, 없다면 없음이라고 명확하게 알려줘. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/hooks/mutations/useStoryMutations.ts`:
- Around line 99-104: The onSuccess handler in useStoryMutations.ts only
invalidates a subset of story caches (storyKeys.detail, storyKeys.infiniteList,
storyKeys.myList and a partial otherMember key), leaving many story views stale;
replace these individual invalidations with a single full invalidation using
storyKeys.all (e.g., call queryClient.invalidateQueries with queryKey:
storyKeys.all) so all story-related queries are refreshed after an edit and
remove the incomplete otherMember invalidation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f75a3f8-35d8-4c86-912a-9309472926c1
📒 Files selected for processing (6)
src/app/(main)/stories/[id]/edit/page.tsxsrc/app/(main)/stories/[id]/page.tsxsrc/hooks/mutations/useStoryMutations.tssrc/lib/api/endpoints/bookstory.tssrc/services/storyService.tssrc/types/story.ts
📌 개요 (Summary)
🛠️ 변경 사항 (Changes)
📸 스크린샷 (Screenshots)
(UI 변경 사항이 있다면 첨부해주세요)
✅ 체크리스트 (Checklist)
pnpm build)pnpm lint)Summary by CodeRabbit
New Features