Skip to content

feat: 책 이야기 수정 구현 - #284

Merged
shinwokkang merged 2 commits into
devfrom
feat/283-bookstroy-edit
May 1, 2026
Merged

shinwokkang merged 2 commits into
devfrom
feat/283-bookstroy-edit

Conversation

@shinwokkang

@shinwokkang shinwokkang commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

📌 개요 (Summary)

  • 변경 사항에 대한 간략한 요약을 적어주세요.
  • 관련 이슈가 있다면 링크를 걸어주세요 (예: [fix] cicd / build 문제 #123).

🛠️ 변경 사항 (Changes)

  • 새로운 기능 추가
  • 버그 수정
  • 코드 리팩토링
  • 문서 업데이트
  • 기타 (설명: )

📸 스크린샷 (Screenshots)

(UI 변경 사항이 있다면 첨부해주세요)

✅ 체크리스트 (Checklist)

  • 빌드가 성공적으로 수행되었나요? (pnpm build)
  • 린트 에러가 없나요? (pnpm lint)
  • 불필요한 콘솔 로그나 주석을 제거했나요?

Summary by CodeRabbit

New Features

  • Users can now edit descriptions of their own stories
  • The edit button is fully functional and accessible from story details
  • Changes are validated and saved with success/error notifications

@shinwokkang shinwokkang self-assigned this Apr 30, 2026
@shinwokkang shinwokkang added the ✨ feat 새로운 기능 추가 label Apr 30, 2026
@vercel

vercel Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
check-mo Ready Ready Preview, Comment May 1, 2026 2:50am
checkmo Ready Ready Preview, Comment May 1, 2026 2:50am

@coderabbitai

coderabbitai Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 81d2f289-4744-423d-aba1-08c622e2f9c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/283-bookstroy-edit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the story editing feature, including a new edit page, navigation updates, and the necessary API and mutation hooks. The review feedback recommends renaming an ambiguously named state variable for better clarity and refactoring the query invalidation logic to ensure all relevant story data is refreshed upon a successful update.

@shinwokkang

Copy link
Copy Markdown
Contributor Author

@coderabbitai 해당 작업에 대해서 hugging face 와 같은 외부 모델 툴들을 사용해서 성능 및 보안 측면에서 더 디벨롭 할 수 있는 부분이 있을까? 있다면 알려주고, 없다면 없음이라고 명확하게 알려줘.
hugging face에 몰두되지 말고 외부 다른 툴이나 라이브러리 및 모델이 있다면 추천해줘. 사용하지 않아도 충분하다면 사용하지 않아도 충분이라고 명확하게 남겨줘.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/hooks/mutations/useStoryMutations.ts`:
- Around line 99-104: The onSuccess handler in useStoryMutations.ts only
invalidates a subset of story caches (storyKeys.detail, storyKeys.infiniteList,
storyKeys.myList and a partial otherMember key), leaving many story views stale;
replace these individual invalidations with a single full invalidation using
storyKeys.all (e.g., call queryClient.invalidateQueries with queryKey:
storyKeys.all) so all story-related queries are refreshed after an edit and
remove the incomplete otherMember invalidation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f75a3f8-35d8-4c86-912a-9309472926c1

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad50c2 and ab9a54f.

📒 Files selected for processing (6)
  • src/app/(main)/stories/[id]/edit/page.tsx
  • src/app/(main)/stories/[id]/page.tsx
  • src/hooks/mutations/useStoryMutations.ts
  • src/lib/api/endpoints/bookstory.ts
  • src/services/storyService.ts
  • src/types/story.ts

@shinwokkang
shinwokkang merged commit 1a15c2a into dev May 1, 2026
4 checks passed
@shinwokkang
shinwokkang deleted the feat/283-bookstroy-edit branch May 1, 2026 02:50

This branch was successfully deployed

2 active deployments
Preview – checkmo — 883a4d8c Deployed May 1, 2026 by vercel[bot]
Preview – check-mo — 883a4d8c Deployed May 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feat 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant