Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idle timer read cmd.Process while process startup wrote it. Use CommandContext and context cancellation so the timer does not access process state. Preserve the existing inactivity timeout and output resets.
Related issues
No linked issue.
Verification
Silent and output-producing command tests pass under the race detector. Built before/after binaries were exercised through the full five-minute timeout; the startup race disappears.
Local checks passed on Go 1.27.1. The CI workflow uses Go 1.26.3.
Checklist
go build ./...andgo test ./...passgofmt -l .andgo vet ./...are cleancheatmd --lint examples/passes