feat: add --keylog flag to record keypresses with timestamps#713
Closed
pkazmier wants to merge 2 commits into
Closed
feat: add --keylog flag to record keypresses with timestamps#713pkazmier wants to merge 2 commits into
pkazmier wants to merge 2 commits into
Conversation
Record key events during tape execution and output them as JSON for use by external subtitle generation or other accessibility tools. Timestamps are derived from frame numbers to ensure accurate alignment with video output. My first version used wall clock, but that resulted in significant drift even in a 30s video (1.35s of drift). This version results in +/- of a frame or two. Key events are not recorded during Hide sections.
pkazmier
requested review from
andreynering and
aymanbagabas
and removed request for
a team
Author
|
This PR has been superseded by PR #719 which adds captioning directly to VHS. I'd prefer to close this one if you'd consider the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record key events during tape execution and output them as JSON for use by external subtitle generation or other accessibility tools.
Timestamps are derived from frame numbers to ensure accurate alignment with video output. My first version used wall clock, but that resulted in significant drift even in a 30s video (1.35s of drift). This version results in +/- of a frame or two.
Key events are not recorded during Hide sections.
See discussion #702 for more details.