Fix issue where some queries would not be added as negative keyword.#2
Open
rmuit wants to merge 4 commits into
Open
Fix issue where some queries would not be added as negative keyword.#2rmuit wants to merge 4 commits into
rmuit wants to merge 4 commits into
Conversation
…onsistently instead of just once. Nothing changed yet.
…querying data in the sheet / Google Ads. Changing some other loops to be better readable too. No behavior really changed, except log levels. (Some reindents make the diff large, though.)
… a query for "green card" would match so it would not be added as a negative keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If "car" was defined in the sheet, a query for "green card" would match so it would not be added as a negative keyword.
Also - I needed to do more work on this script (to do more 'campaign level' support, see my fork) - but found the code somewhat hard to understand. So I did some cleanup / coding standards / reshuffling, in three separate commits, before adding this fix. I hope that's not too pedantic.
Feel free to do whatever you want with this code: merge, cherry pick, rebase, tell me to include the other 'campaign level' support in the same / a new PR...