Skip to content

Use Classes to enforce consistent APIs #107

Open

Description

@collectoss-issue-migrator

Note

Migrated from augurlabs/augur#3272
Originally opened by @MoralCode on 2025-09-15


https://github.com/chaoss/augur/blob/2c9a5f1f2a9b58cfec035982fd0b27bd31cb0fbe/augur/tasks/start_tasks.py#L159

These builders are all intended to use the same APIs and conventions, which is why many of them refer to "enabled phases" when they dont need the ability to have disabled phases. All collection request builders must be able to accept a list of 'enabled_phase_names', even if they are not used.

these should maybe be refactored into instances or subclasses so that the convention of matching signatures is more explicit in its purpose and able to be technically enforced.

Activity

  1. collectoss-issue-migrator commented on Apr 30, 2026

    @collectoss-issue-migrator
    Author

    Note

    Migrated comment from original
    Originally posted by @MoralCode on 2025-09-16


    same applies here https://github.com/chaoss/augur/blob/2c9a5f1f2a9b58cfec035982fd0b27bd31cb0fbe/augur/tasks/util/collection_util.py#L605

    lists of tasks, such as can be seen in facade_phase (variable facade_core_collection)

  2. collectoss-issue-migrator commented on Apr 30, 2026

    @collectoss-issue-migrator
    Author

    Note

    Migrated comment from original
    Originally posted by @Sukuna0007Abhi on 2026-01-11


    I will give it a try @MoralCode , pr augurlabs/augur#3583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions