[auth] Allow a full bind DN as LDAP_USER for LDAP sync#1164
Merged
Conversation
sync-with-ldap-server always built the bind user as uid=<LDAP_USER>,<LDAP_BASE_DN>, which fails with invalidCredentials on OpenLDAP setups where the admin account lives outside the users base DN (e.g. cn=admin,dc=studio,dc=local). When LDAP_USER contains a "=", it is now treated as a full DN and passed to the bind untouched. Fix cgwire#1070 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zou sync-with-ldap-serverfails withLDAPInvalidCredentialsResulton OpenLDAP servers: the bind user is always built asuid=<LDAP_USER>,<LDAP_BASE_DN>, but OpenLDAP admin accounts usually live outside the users base DN (e.g.cn=admin,dc=studio,dc=local), so there is no way to provide a working bind identity.Solution
LDAP_USERcontains a=, treat it as a full bind DN and pass it to the LDAP bind untouched; plain usernames keep the existinguid=...,<base DN>behavior.Fix #1070