[plugins] Escape percent signs in Alembic database URL#1163
Merged
frankrousseau merged 1 commit intoJul 13, 2026
Merged
Conversation
Plugin migrations crashed at install time when the PostgreSQL password contained percent-encoded characters (e.g. "!" encoded as "%21"), because configparser treats "%" as an interpolation token. Apply the same escaping as the core migration config in cli.py. Fix cgwire#1117 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zou install-plugincrashes when the PostgreSQL password contains special characters (e.g.!): the password is percent-encoded in the SQLAlchemy URL and configparser, used internally by Alembic, rejects the resulting%sequences as invalid interpolation tokens.Solution
%as%%when settingsqlalchemy.urlin the plugin Alembic config, exactly like the core migration config already does incli.py. The value is unescaped back by configparser when env.py reads it.Fix #1117