Fix preview delete crash, pip-audit gate and CLI SECRET_KEY guard#1162
Merged
Conversation
update_preview_file_raw catches StaleDataError when a preview row is deleted mid-update, but read preview_file.id after base.update() had rolled back and expired the instance. That reload hit the deleted row and raised an unhandled ObjectDeletedError instead of a clean 404. Capture the id before update() so the handler never re-touches the expired instance. Tests: test_update_preview_file_raw_deleted_midflight_raises_not_found Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pip-audit started failing on two new advisories. Bump pillow to 12.3.0 to clear PYSEC-2026-2253 through PYSEC-2026-2257. pyopenssl PYSEC-2026-2269 is fixed only in 26.0.0, which pysaml2 7.5.4 blocks via its pyopenssl<24.3 cap, so add it to the ignore list alongside the documented chain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
update_preview_file_rawreadspreview_file.idin itsStaleDataErrorhandler after the failed commit expired the instance, raising an unhandledObjectDeletedErrorinstead of a clean 404 when a preview is deleted mid-update.zouconsole script, sopython zou/cli.pyandpython -m zou.cliare wrongly blocked.Solution
update()so the handler never re-touches the expired ORM instance.pyopenssl<24.3cap.__main__module iscli.py.