[auth] Exempt direct CLI invocation from SECRET_KEY guard#1161
Merged
Conversation
The default-SECRET_KEY guard exempted the CLI by checking for "zou.cli" in sys.modules, but that name only appears when the `zou` console script imports it. Running `python zou/cli.py` or `python -m zou.cli` executes cli.py as __main__, so the exemption missed those paths and the CLI refused to start. Also match on the __main__ module being cli.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
python zou/cli.py <cmd>andpython -m zou.cli <cmd>refused to start with the insecure-defaultSECRET_KEYerror, even though CLI runs are meant to be exempt.Solution
__main__module iscli.py, not only whenzou.cliis imported (which only thezouconsole-script entry point triggers). Server boot still refuses the default key.