Skip to content

[shots] Answer 400 without error log on bad OTIO import files#1158

Merged
frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:fix-otio-unsupported-file
Jul 10, 2026
Merged

[shots] Answer 400 without error log on bad OTIO import files#1158
frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:fix-otio-unsupported-file

Conversation

@frankrousseau

Copy link
Copy Markdown
Contributor

Problems

  • Uploading a file OTIO cannot read (e.g. a csv) on /import/otio answered 400 through a catch-all that logged every user mistake as a server error, flooding Sentry.

Solutions

  • Validate the suffix against the OTIO adapters up front and raise WrongParameterException for unsupported or unparseable files: clean 400 with an explicit message, no error log; the catch-all stays for genuine internal failures.

Uploading a file OTIO cannot read (e.g. a csv) already answered 400, but
through a catch-all that logged every user mistake as a server error,
flooding Sentry. Validate the suffix against the OTIO adapters up front
and raise WrongParameterException for unsupported or unparseable files:
clean 400 with an explicit message, no error log. The catch-all and its
error log remain for genuine internal failures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@frankrousseau
frankrousseau merged commit 63f8567 into cgwire:main Jul 10, 2026
4 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant