[previews] Missing-file 404 and batch route hardening#1154
Merged
frankrousseau merged 2 commits intoJul 10, 2026
Conversation
frankrousseau
changed the title
frankrousseau
force-pushed
the
fix-missing-remote-file-404
branch
from
July 10, 2026 12:23
16cd418 to
f61d646
Compare
On S3/Swift backends, a download that reported success but produced an empty or missing file raised DownloadFromStorageFailedException, which no handler caught, so preview/thumbnail requests 500ed. Raise FileNotFound instead, matching the local backend and the existing not-found handling that returns 404. The now-unused exception class is removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The batch delete-entities route fetched every entity in both the authorization loop and remove_entities, so an id already deleted by someone else raised EntityNotFoundException and failed the whole batch. Skip absent entities in both loops: the deletion is idempotent and mirrors remove_tasks, which ignores unknown ids. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
frankrousseau
force-pushed
the
fix-missing-remote-file-404
branch
from
July 10, 2026 12:37
f61d646 to
570eb6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solutions