Skip to content

[tasks] Return 400 when setting main preview without a preview#1153

Merged
frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:fix-set-main-preview-no-preview
Jul 10, 2026
Merged

[tasks] Return 400 when setting main preview without a preview#1153
frankrousseau merged 1 commit into
cgwire:mainfrom
frankrousseau:fix-set-main-preview-no-preview

Conversation

@frankrousseau

@frankrousseau frankrousseau commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Problems

  • PUT /actions/tasks//set-main-preview fell through to return None (Flask 500) when the task had no preview file to promote.

Solutions

  • Answer with a 400 and an explicit message telling the task has no preview file to set as main preview.

SetTaskMainPreviewResource fell through to return None (Flask 500) when
the task had no preview file to promote. Answer with an explicit 400 and
a message telling the task has no preview file to set as main preview.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@frankrousseau frankrousseau changed the title [tasks] Return 404 when setting main preview without a preview [tasks] Return 400 when setting main preview without a preview Jul 10, 2026
@frankrousseau
frankrousseau force-pushed the fix-set-main-preview-no-preview branch from f1e06be to 0f8b463 Compare July 10, 2026 11:59
@frankrousseau
frankrousseau merged commit da68247 into cgwire:main Jul 10, 2026
2 checks passed
@frankrousseau
frankrousseau deleted the fix-set-main-preview-no-preview branch July 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant