[persons] Let datetime validate interval helper inputs#1151
Merged
Conversation
frankrousseau
force-pushed
the
allow-future-day-offs
branch
from
July 10, 2026 11:56
5d5089e to
aa21e36
Compare
get_month_interval and the year/week/day helpers enforced an arbitrary year range (2010 to the current year), so viewing a future month (e.g. day offs for 2027/01 while in 2026) raised WrongDateFormatException and a 500, while genuinely impossible dates slipped through the manual bounds (Feb 30 passed the day <= 31 check and crashed, non-numeric input crashed before the check, ISO week 53 was wrongly rejected). Drop the range policy: build the interval and let datetime decide, converting ValueError into WrongDateFormatException. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
frankrousseau
changed the title
frankrousseau
force-pushed
the
allow-future-day-offs
branch
from
July 10, 2026 12:22
aa21e36 to
c270531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solutions