Skip to content

Fix asset matching in task type CSV import#1113

Open
NicoPennec wants to merge 1 commit into
cgwire:mainfrom
NicoPennec:import
Open

Fix asset matching in task type CSV import#1113
NicoPennec wants to merge 1 commit into
cgwire:mainfrom
NicoPennec:import

Conversation

@NicoPennec

Copy link
Copy Markdown
Member

Problem

  • During task type estimations CSV import, the asset lookup key was built from literal text instead of the asset-type slug, so no asset row ever matched (regression from the %-to-f-string conversion in bf7d4fe).

Solution

  • Rebuild the asset key by interpolating the asset-type slug and the asset name, restoring the original matching behavior.
  • Report the raw CSV Parent/Entity values in the "not found" error instead of the internal slugified key, so the user can fix their file.

The asset lookup key was built from literal text instead of the
asset-type slug, so no asset row ever matched. Regression from
bf7d4fe (% to f-string conversion).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant