[players] Migrate annotation stack to fabric.js 7#2044
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Follow-up (non-blocking): the cgwire/fabric.js v5-snapshot fork is no longer referenced by Kitsu since the v6 migration — it can be archived once we confirm nothing else depends on it. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
The annotation-loss fix in this branch has a server-side complement: cgwire/zou#1105 adds a |
Drive the whole widget through diff2html's own --d2h-* design tokens instead of overriding it class-by-class, so light and dark are themed from a single token set that follows Kitsu's variables. Keep code text high-contrast neutral and carry add/delete through row tint plus word-level highlights (the old green/red text on a green/red row was unreadable, and the default light theme leaked white into dark mode). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff2html silently returns an empty render when the content is not a valid unified diff (e.g. a pretty-printed summary with no ---/+++ or @@ headers and line numbers baked into each line), leaving the viewer blank. Detect the empty render and show the raw content in a readable monospace block instead of nothing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
fabric@6.9.1while fabric 7 is the current major (canvas 3, node 20+, jsdom 26).originX/originYto'center': every Kitsu shape is created and serialised by its top-left corner, so new drawings and previously-saved annotations would render shifted by half a dimension.fabricjs-psbrushwas still pinned to a personal fork branch instead of the upstream cgwire repo.Solutions
fabricto7.4.0and repointfabricjs-psbrushtocgwire/fabricjs-psbrush(peer range widened to^6 || ^7in [deps] Accept fabric 7 as a peer dependency fabricjs-psbrush#2, prerequisite).left/topdefault origin globally viaFabricObject.ownDefaultsat annotation module init, with a regression test.Math.round, matching the marker position; bar clicks keepfloor.mergeAnnotationsByFrame). Server-side cleanup of the legacy entries: [previews] Add a command to normalize annotation times zou#1105.