build: use vcpkg as a submodule#2
Open
ReenigneArcher wants to merge 1 commit into
Open
Conversation
Closed
20 tasks
lurebat
pushed a commit
to lurebat/WinUHid
that referenced
this pull request
Apr 29, 2026
- Add MicLedCallback parameter to WinUHidPS5Create FFI binding - Add FirmwareInfo/FirmwareInfoLength fields to WINUHID_PS5_GAMEPAD_INFO - Add MicLed device event variant and callback implementation - Document mic_led WebSocket message type in web/README.md - Update README.md to reference just install-driver and BUILDING.md - Note vcpkg is now a Git submodule (PR cgutman#2) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds vcpkg as a submodule instead of using a GitHub action to set it up. The version of vcpkg is the latest release. If you add dependabot, they will now only update to tagged versions, if the existing version is also a tagged version.
I also made the upload step fail if no artifacts are found.
Motivation
I've been looking into how to integrate this into Sunshine, and currently it's not the easiest to integrate into Sunshine's build process. Using vcpkg as a submodule would make it a little easier... I think.
I'm not completely sure what all is required/remaining before this can be integrated into Sunshine. If code signing is a limitation, I do have a code signing account now through Azure (though it does not support ARM64 yet).
Note
Some of the builds are failing, but that is not due to the changes in this PR as I get the same errors when running the workflow for the main branch: https://github.com/ReenigneArcher/WinUHid/actions/runs/23274527994