Fix Swift Package Manager support (v1.4.2)#41
Merged
Conversation
- Update BundleLoader to use Bundle.module for SPM builds - Add defaultLocalization to Package.swift for localized resources - Fix Package.swift resource paths for proper SPM compatibility - Add SPM installation instructions to README - Bump version to 1.4.2 in podspec - Add .build to .gitignore
There was a problem hiding this comment.
Pull request overview
This PR fixes Swift Package Manager (SPM) support for TvOSMoreButton by addressing bundle loading issues that prevented proper resource access when the library is consumed via SPM. The changes maintain backward compatibility with CocoaPods and Carthage while properly supporting SPM builds. Version bumped to 1.4.2.
- Updates
BundleLoaderto useBundle.modulefor SPM builds while maintaining CocoaPods/Carthage compatibility - Configures
Package.swiftwith proper paths, exclusions, and localization support - Updates documentation with SPM installation instructions and version references
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Private/Helpers/BundleLoader.swift | Adds conditional compilation to use Bundle.module for SPM builds while preserving existing CocoaPods bundle loading logic |
| Package.swift | Adds defaultLocalization, updates root path with proper source/resource configuration and comprehensive exclusions list |
| TvOSMoreButton.podspec | Bumps version to 1.4.2 |
| README.md | Adds SPM installation instructions and updates version references to 1.4.2 |
| CHANGELOG.md | Documents 1.4.2 release with SPM fixes |
| .gitignore | Adds SPM build directory to gitignore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cgoldsby with CocoaPods going into read-only mode, this PR adds Swift Package Manager support.