Skip to content

TA-3767: Migrate Studio commands#202

Merged
Zgjim Haziri (ZgjimHaziri) merged 39 commits into
content-cli-v2-refactoringfrom
TA-3767-migrate-studio-commands
May 22, 2025
Merged

TA-3767: Migrate Studio commands#202
Zgjim Haziri (ZgjimHaziri) merged 39 commits into
content-cli-v2-refactoringfrom
TA-3767-migrate-studio-commands

Conversation

@ZgjimHaziri

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Migrated Studio commands into the new structure.
  • The code logic is copy-pasted, besides some things like e.g. dependency management, restructuring, command definition format.
  • Removed profile management logic from the services.
  • Removed profile management logic from base manager. This is now provided by the tool.
    • This is not an ideal state, but wanted to keep the existing pattern and leave it to the command owners to decide if they want to change it.

Relevant links

Jira issue: https://celonis.atlassian.net/browse/TA-3767

Notes

I would suggest to review the code along with some functional testing of the commands. This will make easier reviewing the large number of added lines here.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@lippisch
Adding minor comments
6b2d53b
@lippisch
Profile is now loaded as part of the context
2145ce2
@lippisch
Logger now writes logs into the config directory
97a056d
@lippisch
fix for --debug
1b0bbde
@lippisch
Migrated list command as an example implementation
101a96c
@lippisch
modules can extend any root level command
0ab31e0
@lippisch
entry point file can be of 3 variants now, supporting foldername as p…
7c23b97 
…refix.
@lippisch
Merge remote-tracking branch 'origin/master' into fli-contribution-mo…
9fba40f 
…del-refactoring
@lippisch
Modules are now structured by owning team, not command structure
5ab1e34
@lippisch
Base API with some refactored error handling
5f107c1
@lippisch
minor tweaks to align with documentation
601623d
@ZgjimHaziri
TA-3749: Define foundation of the CLI
0b60d45
@ZgjimHaziri
TA-3749: Revert unnecessary change
38f86e7
@ZgjimHaziri
TA-3749: Revert unnecessary change
6f4f515
@ZgjimHaziri
TA-3749: Revert unnecessary change
128fcab
@ZgjimHaziri
TA-3749: Revert unnecessary change
b624e74
@ZgjimHaziri
TA-3749: yarn-lock update
f5e25b8
@ZgjimHaziri
TA-3749: Rever package.json update
5b4a283
@ZgjimHaziri
TA-3749: Move code to top level
7f6cc1b
@ZgjimHaziri
Merge base branch
0726a23
@ZgjimHaziri
TA-3749: Trigger build
4351014
@ZgjimHaziri
TA-3749: Comment test run
843f7b5
@ZgjimHaziri
TA-3750: Setup command modules
d88b9a4
@ZgjimHaziri
TA-3750: Merge base branch insto TA-3750-setup-modules
e3cb10f
@ZgjimHaziri
TA-3750: Rename Pacman module to Config
375f56c
@ZgjimHaziri
TA-3750: Remove non-Astro codeowners
ba51325
@ZgjimHaziri
TA-3750: Update Pacman module description
d2ff658
@ZgjimHaziri
TA-3750: Fix merge conflicts
633f4fd
@ZgjimHaziri
TA-3750: Rename config module
715fe90
@ZgjimHaziri
TA-3750: Rename config module in codeowners file
14be28d
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner May 20, 2025 13:42
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team May 20, 2025 13:57
LaberionAjvazi
Laberion Ajvazi (LaberionAjvazi) reviewed May 20, 2025
View reviewed changes
Comment thread src/commands/studio/api/batch-import-export-api.ts Outdated
Comment thread src/commands/studio/api/variables-api.ts Outdated
Comment thread src/commands/studio/interfaces/batch-export-import.constants.ts Outdated
Comment thread src/commands/studio/interfaces/variable-assignment-apis.constants.ts Outdated
Comment thread src/commands/studio/service/variable.service.ts Outdated
promeris
Meris Nici (promeris) reviewed May 20, 2025
View reviewed changes
Comment thread src/commands/studio/api/batch-import-export-api.ts Outdated
Comment thread src/commands/studio/interfaces/manifest.interface.ts
@ZgjimHaziri

Zgjim Haziri (ZgjimHaziri) commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

Agree with the above comments. The idea was to keep everything used by Studio commands here, and then move the Pacman-related things as part of the Pacman migration PR. Will move them to Pacman in the following commit here.

Base automatically changed from TA-3771-migrate-data-pipeline to content-cli-v2-refactoring May 22, 2025 07:55
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit 2c2e5d2 into content-cli-v2-refactoring May 22, 2025
1 check passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the TA-3767-migrate-studio-commands branch May 22, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksalihu Kastriot Salihu (ksalihu) ksalihu approved these changes

@jetakasabaqi Jeta (jetakasabaqi) jetakasabaqi left review comments

@promeris Meris Nici (promeris) promeris left review comments

@Buqeta Buqeta (Buqeta) Buqeta left review comments

@LaberionAjvazi Laberion Ajvazi (LaberionAjvazi) LaberionAjvazi left review comments

@Dusan-r Dusan Radosavljevic (Dusan-r) Awaiting requested review from Dusan-r

@IvanGandacov Ivan Gandacov (IvanGandacov) Awaiting requested review from IvanGandacov

@EktaCelonis Ekta Dubey (EktaCelonis) Awaiting requested review from EktaCelonis

@gorasoCelonis Oleg Goras (gorasoCelonis) Awaiting requested review from gorasoCelonis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZgjimHaziri @jetakasabaqi @promeris @Buqeta @LaberionAjvazi @ksalihu @lippisch