Skip to content

TA-3771: Migrate Data Pipeline commands#201

Merged
Zgjim Haziri (ZgjimHaziri) merged 33 commits into
content-cli-v2-refactoringfrom
TA-3771-migrate-data-pipeline
May 22, 2025
Merged

TA-3771: Migrate Data Pipeline commands#201
Zgjim Haziri (ZgjimHaziri) merged 33 commits into
content-cli-v2-refactoringfrom
TA-3771-migrate-data-pipeline

Conversation

@ZgjimHaziri

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) commented May 19, 2025

Copy link
Copy Markdown
Contributor

Description

  • Migrated Data Pipeline commands into the new structure.
  • Removed profile management logic from the services.
  • Fixed some error logging with profile service.
  • Removed profile management logic from base manager and provided it as a service from the tool.
    • This is not an ideal state, but wanted to keep the existing pattern and leave it to the owners to decide if they want to change it.
    • Here we're now providing:
      • BaseManager: Util class which provides a way for defining the HTTP request. This is an abstract class that's extended by multiple commands in the CLI.
      • Content Service: Util for using BaseManager implementations.

Relevant links

Jira issue: https://celonis.atlassian.net/browse/TA-3771

Notes

I would suggest to review the code along with some functional testing of the commands. This will make easier reviewing the large number of added lines here.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) requested a review from a team as a code owner May 19, 2025 07:57
Base automatically changed from TA-3750-setup-modules to content-cli-v2-refactoring May 19, 2025 08:33
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) merged commit 276ea4f into content-cli-v2-refactoring May 22, 2025
1 check passed
@ZgjimHaziri Zgjim Haziri (ZgjimHaziri) deleted the TA-3771-migrate-data-pipeline branch May 22, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants