docs(cip-43): clarify from_address refers to module account#382
Conversation
Address review comment: #381 (comment) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @Manav-Aggarwal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a small but useful clarification in the documentation for CIP-43, specifying that the from_address is a module account. The change is correct and improves clarity. I've added one suggestion to further improve the document's readability by linking to the relevant section.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| ``` | ||
|
|
||
| The `from_address` field is always set to the fee address. The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`. | ||
| The `from_address` field is always set to the [fee address module account](#fee-address). The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`. |
There was a problem hiding this comment.
I don't think the link to the section above is intentional
| The `from_address` field is always set to the [fee address module account](#fee-address). The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`. | |
| The `from_address` field is always set to the fee address module account. The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`. |
Summary
from_addressis set to the fee address module accountAddresses review comment: #381 (comment)
Test plan
🤖 Generated with Claude Code