Skip to content

docs(cip-43): clarify from_address refers to module account#382

Merged
Manav-Aggarwal merged 2 commits into
mainfrom
Manav-Aggarwal/cip43-comment-fix
Jan 23, 2026
Merged

docs(cip-43): clarify from_address refers to module account#382
Manav-Aggarwal merged 2 commits into
mainfrom
Manav-Aggarwal/cip43-comment-fix

Conversation

@Manav-Aggarwal

Copy link
Copy Markdown
Member

Summary

  • Clarifies that from_address is set to the fee address module account

Addresses review comment: #381 (comment)

Test plan

  • Verified markdown renders correctly

🤖 Generated with Claude Code

Address review comment: #381 (comment)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Manav-Aggarwal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity of the CIP-043 documentation by explicitly stating that the from_address field, in the context of the MsgPayProtocolFee message, refers to the fee address module account. This change directly addresses a specific review comment, ensuring the documentation is more precise and unambiguous for readers.

Highlights

  • Documentation Clarification: Clarified that the from_address field in cip-043.md refers specifically to the "fee address module account" to improve understanding and address a previous review comment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Manav-Aggarwal Manav-Aggarwal self-assigned this Jan 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a small but useful clarification in the documentation for CIP-43, specifying that the from_address is a module account. The change is correct and improves clarity. I've added one suggestion to further improve the document's readability by linking to the relevant section.

Comment thread cips/cip-043.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread cips/cip-043.md
```

The `from_address` field is always set to the fee address. The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`.
The `from_address` field is always set to the [fee address module account](#fee-address). The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the link to the section above is intentional

Suggested change
The `from_address` field is always set to the [fee address module account](#fee-address). The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`.
The `from_address` field is always set to the fee address module account. The message includes a signer annotation for SDK compatibility, but signature verification is skipped by the `ProtocolFeeTerminatorDecorator`. Validation happens via ProcessProposal checking that `tx fee == fee address balance`.

@Manav-Aggarwal
Manav-Aggarwal merged commit 5d7c363 into main Jan 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants