Add Notional DUNE model#14
Open
elliottbiondo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@stognini ready for your review |
stognini
reviewed
Jun 24, 2026
| { | ||
| case GID::box: | ||
| return "Lead box"; | ||
| break; |
Member
There was a problem hiding this comment.
Nice. Never noticed the unnecessary breaks everywhere.
Member
|
Looks great! Could you add this to the README as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds a notional model of DUNE, which will be used to test how state size affects runtime. It consists of a liquid argon cube with N^3 spheres of copper, and M concentric vacuum boxes. The copper spheres are daughters in the background volume, as the anode is in the actual model. The concentric vacuum boxes do not affect the transport results, be each layer adds depth to the nested structure of universes thereby increasing the state size. The image below shows GDML output with 1000 spheres within three concentric vacuum boxes.