Fix tessellated solid#47
Merged
Merged
Conversation
sethrj
approved these changes
Jun 11, 2026
sethrj
left a comment
Member
There was a problem hiding this comment.
Excellent! Thanks for the fix and test.
Collaborator
Author
|
Thank you for the quick merge @sethrj. Would it be possible to stamp a new version with the fix in? Then we can update AdePT / Celeritas to pull the latest version including the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a nasty little bug in the conversion of the tessellated solid:
The VecGeom function
AddTriangularFacetdiffers from theG4TriangularFacet:In the VecGeom function, the final argument is a simple boolean:
passing the Geant4 enum
ABSOLUTEevaluates to 0:so in this case, it was always set to
absolute = false, leading to a bug.A unit test with a ray is added to make sure the result is as expected.