Add ldg function to Range#2426
Conversation
Test summary 5 701 files 9 289 suites 18m 41s ⏱️ Results for commit 4fa7592. ♻️ This comment has been updated with latest results. |
|
However the Windows failure is odd ... :( |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2426 +/- ##
===========================================
- Coverage 87.32% 87.31% -0.01%
===========================================
Files 1401 1401
Lines 44444 44446 +2
Branches 13495 13958 +463
===========================================
+ Hits 38809 38810 +1
- Misses 4410 4564 +154
+ Partials 1225 1072 -153
🚀 New features to boost your workflow:
|
It's not clear whether this was an MSVC compiler bug (likely) or clang and GCC being permissive, but somehow it seems that the namespace lookup was being broken by a combination of templates, friends, and detail namespaces: adding I'm glad we have MSVC on our CI, because it would've been a hell of a lot more complicated to track down with 50k other changes… |
This adds
ldgfriends toRangeandnItemMapto support loading from const collections. It also replaces troublesome implicit constructors with standard explicit ones.