Skip to content

Add ldg function to Range#2426

Open
sethrj wants to merge 8 commits into
celeritas-project:developfrom
sethrj:ldg-range
Open

Add ldg function to Range#2426
sethrj wants to merge 8 commits into
celeritas-project:developfrom
sethrj:ldg-range

Conversation

@sethrj

@sethrj sethrj commented Jun 16, 2026

Copy link
Copy Markdown
Member

This adds ldg friends to Range andn ItemMap to support loading from const collections. It also replaces troublesome implicit constructors with standard explicit ones.

@sethrj sethrj requested a review from esseivaju June 16, 2026 13:46
@sethrj sethrj added core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes performance Changes for performance optimization labels Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Test summary

 5 701 files   9 289 suites   18m 41s ⏱️
 2 326 tests  2 283 ✅  43 💤 0 ❌
32 901 runs  32 730 ✅ 171 💤 0 ❌

Results for commit 4fa7592.

♻️ This comment has been updated with latest results.

@pcanal pcanal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pcanal

pcanal commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

However the Windows failure is odd ... :(

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.31%. Comparing base (d10bc05) to head (4fa7592).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2426      +/-   ##
===========================================
- Coverage    87.32%   87.31%   -0.01%     
===========================================
  Files         1401     1401              
  Lines        44444    44446       +2     
  Branches     13495    13958     +463     
===========================================
+ Hits         38809    38810       +1     
- Misses        4410     4564     +154     
+ Partials      1225     1072     -153     
Files with missing lines Coverage Δ
src/corecel/OpaqueId.hh 100.00% <ø> (ø)
src/corecel/cont/Range.hh 100.00% <100.00%> (ø)
src/corecel/cont/detail/LdgSpanImpl.hh 100.00% <100.00%> (ø)
src/corecel/cont/detail/RangeImpl.hh 99.00% <100.00%> (+0.01%) ⬆️
src/corecel/data/Collection.hh 100.00% <ø> (ø)
src/corecel/data/Ldg.hh 90.00% <ø> (ø)

... and 113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sethrj

sethrj commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

However the Windows failure is odd ... :(

It's not clear whether this was an MSVC compiler bug (likely) or clang and GCC being permissive, but somehow it seems that the namespace lookup was being broken by a combination of templates, friends, and detail namespaces: adding using ::celeritas::ldg allows it to resolve.

I'm glad we have MSVC on our CI, because it would've been a hell of a lot more complicated to track down with 50k other changes…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes performance Changes for performance optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants