Add optical step gather action#2349
Draft
Rashika-Gupta wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of step 1 from #1746, adding the infrastructure to gather optical step data into aux state during simulation.
Adds:
OpticalStepStateData: state collection holding per-track slot, position, and volume ID for pre/post step pointsOpticalStepParams: AuxParams implementation registered with the aux registry,OpticalStepGatherExecutor<StepPoint P>: per-track functor that copies data from CoreTrackView into the step state; currently writes JSON output to optical_steps.jsonl as a debugging aidOpticalStepGatherAction:OpticalStepActionInterfacethat launches pre- and post-step executors; registered in CoreParams whenCELER_OPTICAL_STEPenv var is setKnown issues / cleanup needed before ready:
OpticalStepInterface.hhis unused and should be removed