Use robust geometry status for VecGeom to support VecGeom 2#2330
Draft
sethrj wants to merge 16 commits into
Draft
Use robust geometry status for VecGeom to support VecGeom 2#2330sethrj wants to merge 16 commits into
sethrj wants to merge 16 commits into
Conversation
sethrj
added
enhancement
Test summary 5 086 files 8 291 suites 7m 35s ⏱️ For more details on these failures, see this check. Results for commit 4015e61. ♻️ This comment has been updated with latest results. |
Store GeoStatus and surface normal in VecgeomStateData alongside position and direction. Update resize to initialize new fields. In VecgeomTrackView, replace the temporary bool failed_ member with a persistent GeoStatus stored in state, add geo_status() getter/setter, update failed() to check for GeoStatus::error, and change normal() to return a const reference to the cached state field. Prompt: "It looks like `ninja test/geocel/vg_Vecgeom && ctest -R Vecgeom` shows all tests pass." Assisted-by: GitHub Copilot (claude-sonnet-4-5)
This reverts commit 433f2e6.
This reverts commit d24436cb0bfca0c2ee1236ac9f48d2829167f288.
Store GeoStatus and surface normal in VecgeomStateData alongside position and direction. Update resize to initialize new fields. In VecgeomTrackView, replace the temporary bool failed_ member with a persistent GeoStatus stored in state, add geo_status() getter/setter, update failed() to check for GeoStatus::error, and change normal() to return a const reference to the cached state field. Prompt: "Now use your best guess from the earlier diff to add assertions and conditionals relating to the geo status. Again, for this changeset, do not build nor test." Assisted-by: GitHub Copilot (claude-sonnet-4-5)
In move_to_boundary, replace the direction-as-placeholder normal with the approach from PR celeritas-project#1926: use VecGeom's VUnplacedVolume::Normal() to compute the surface normal in local coordinates, then transform back to global via InverseTransformDirection. If the normal is invalid, log an error and fall back to the direction of travel. Prompt: "I still want to cache the value, but please apply the code from Assisted-by: GitHub Copilot (claude-sonnet-4-5) celeritas-project#1926 to replace the placeholder."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHAINED on #2328
This adds a boundary crossing status for VecGeom and eliminates the need for bumps, and I think allow most existing code to work . Current issues: