Improve testing for field integration edge case#2248
Merged
sethrj merged 14 commits intoFeb 10, 2026
Conversation
Test summary 5 913 files 9 451 suites 18m 56s ⏱️ Results for commit ec7e948. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2248 +/- ##
===========================================
- Coverage 86.86% 86.85% -0.01%
===========================================
Files 1330 1330
Lines 42160 42159 -1
Branches 12985 12984 -1
===========================================
- Hits 36621 36617 -4
Misses 4338 4338
- Partials 1201 1204 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the CMSE crossing-in-field test and enables it for ORANGE. This will improve the ability to set and check reference results for #2245 and #2133.
The failures in the ORANGE crossing (similar to the ones @elliottbiondo noticed with ATLAS) could be useful for further debugging, and the "zero step" return value also reminded me that we do have special treatment for reentrant next-distance in ORANGE, returning a zero-step hit explicitly.