Skip to content

Improve testing for field integration edge case#2248

Merged
sethrj merged 14 commits into
celeritas-project:developfrom
sethrj:field-test-improvements
Feb 10, 2026
Merged

Improve testing for field integration edge case#2248
sethrj merged 14 commits into
celeritas-project:developfrom
sethrj:field-test-improvements

Conversation

@sethrj

@sethrj sethrj commented Feb 8, 2026

Copy link
Copy Markdown
Member

This refactors the CMSE crossing-in-field test and enables it for ORANGE. This will improve the ability to set and check reference results for #2245 and #2133.

The failures in the ORANGE crossing (similar to the ones @elliottbiondo noticed with ATLAS) could be useful for further debugging, and the "zero step" return value also reminded me that we do have special treatment for reentrant next-distance in ORANGE, returning a zero-step hit explicitly.

@sethrj sethrj added documentation Documentation and examples geometry Geometry-related features (geocel) labels Feb 8, 2026
@github-actions

github-actions Bot commented Feb 8, 2026

Copy link
Copy Markdown

Test summary

 5 913 files   9 451 suites   18m 56s ⏱️
 2 151 tests  2 123 ✅  28 💤 0 ❌
32 338 runs  32 178 ✅ 160 💤 0 ❌

Results for commit ec7e948.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.85%. Comparing base (2d16294) to head (ec7e948).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2248      +/-   ##
===========================================
- Coverage    86.86%   86.85%   -0.01%     
===========================================
  Files         1330     1330              
  Lines        42160    42159       -1     
  Branches     12985    12984       -1     
===========================================
- Hits         36621    36617       -4     
  Misses        4338     4338              
- Partials      1201     1204       +3     
Files with missing lines Coverage Δ
src/celeritas/field/FieldPropagator.hh 95.18% <100.00%> (ø)
src/orange/OrangeParams.cc 88.57% <100.00%> (-0.11%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sethrj
sethrj merged commit 1633d84 into celeritas-project:develop Feb 10, 2026
42 checks passed
@sethrj
sethrj deleted the field-test-improvements branch February 10, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation and examples geometry Geometry-related features (geocel)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant