Investigate and simplify ORANGE construction warning/debug messages #2247
Merged
Conversation
sethrj
added
enhancement
sethrj
marked this pull request as draft
February 8, 2026 20:57
Test summary 5 571 files 8 939 suites 18m 27s ⏱️ Results for commit 50ce536. ♻️ This comment has been updated with latest results. |
sethrj
force-pushed
the
merge-region-bbox
branch
from
February 10, 2026 16:00
2033886 to
8071ed6
Compare
sethrj
marked this pull request as ready for review
February 10, 2026 16:29
Member
Author
|
@elliottbiondo @esseivaju This is now ready for review. Thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2247 +/- ##
===========================================
- Coverage 86.88% 86.85% -0.04%
===========================================
Files 1331 1331
Lines 42212 42211 -1
Branches 13462 13449 -13
===========================================
- Hits 36676 36661 -15
- Misses 4517 4532 +15
+ Partials 1019 1018 -1
🚀 New features to boost your workflow:
|
sethrj
enabled auto-merge (squash)
February 11, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on to #2239 to check the significance of some of the messages about merging regions. It reduces most of the diagnostics down to debug, and then eliminates some of those. When regions are merged logically, this now intersects the bounding zones, providing even tighter bounds for improving runtime performance. (Thanks to the diagnostic in #2244 we can confirm that indeed does make at least one infinite box finite!)