Skip to content

Add per track reseeding#2229

Merged
sethrj merged 29 commits into
celeritas-project:developfrom
davidsgr:add_per_track_reseeding
Mar 3, 2026
Merged

Add per track reseeding#2229
sethrj merged 29 commits into
celeritas-project:developfrom
davidsgr:add_per_track_reseeding

Conversation

@davidsgr

@davidsgr davidsgr commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Enables the random number generator to be reseeding for every new track primary or secondary. This is enabled through a conditional set at configuration.

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Test summary

 6 010 files   9 629 suites   18m 44s ⏱️
 2 194 tests  2 165 ✅  29 💤 0 ❌
32 886 runs  32 745 ✅ 141 💤 0 ❌

Results for commit e8d7215.

♻️ This comment has been updated with latest results.

@davidsgr
davidsgr marked this pull request as draft February 4, 2026 19:49
@davidsgr davidsgr added enhancement New feature or request core Software engineering infrastructure (corecel) labels Feb 6, 2026
@davidsgr davidsgr self-assigned this Feb 6, 2026
@davidsgr
davidsgr force-pushed the add_per_track_reseeding branch from 8a70af1 to 9e36ccd Compare February 9, 2026 13:05
@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.19%. Comparing base (f90aea9) to head (fd75e53).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/accel/LocalOpticalGenOffload.cc 80.00% 0 Missing and 1 partial ⚠️
src/accel/LocalOpticalTrackOffload.cc 80.00% 0 Missing and 1 partial ⚠️
src/accel/LocalTransporter.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2229      +/-   ##
===========================================
+ Coverage    87.17%   87.19%   +0.01%     
===========================================
  Files         1353     1354       +1     
  Lines        43035    43085      +50     
  Branches     13184    13684     +500     
===========================================
+ Hits         37517    37569      +52     
- Misses        4311     4495     +184     
+ Partials      1207     1021     -186     
Files with missing lines Coverage Δ
src/celeritas/ext/GeantTrackReconstruction.cc 94.73% <100.00%> (+0.39%) ⬆️
src/celeritas/ext/GeantTrackReconstruction.hh 100.00% <ø> (ø)
src/celeritas/global/CoreTrackView.hh 88.46% <ø> (ø)
src/celeritas/io/JsonEventReader.cc 86.66% <100.00%> (+0.45%) ⬆️
src/celeritas/io/RootEventReader.cc 64.17% <100.00%> (+0.54%) ⬆️
src/celeritas/phys/Primary.hh 100.00% <ø> (ø)
src/celeritas/phys/PrimaryGenerator.cc 92.68% <100.00%> (+0.09%) ⬆️
src/celeritas/track/TrackInitData.hh 96.96% <ø> (ø)
...celeritas/track/detail/ProcessPrimariesExecutor.hh 100.00% <ø> (ø)
...leritas/track/detail/ProcessSecondariesExecutor.hh 100.00% <ø> (ø)
... and 6 more

... and 110 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsgr
davidsgr marked this pull request as ready for review February 9, 2026 17:27
@davidsgr

davidsgr commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

@sethrj This is ready for review. I'm not sure if I added a compiler flag correctly, so take a look

Comment thread src/accel/LocalTransporter.cc Outdated
Comment thread src/celeritas/phys/PrimaryGenerator.cc Outdated
Comment thread src/celeritas/track/detail/ProcessPrimariesExecutor.hh Outdated
Comment thread src/celeritas/track/detail/ProcessSecondariesExecutor.hh Outdated
Comment thread CMakeLists.txt

@sethrj sethrj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks greg.

Comment thread src/accel/LocalTransporter.cc Outdated
Comment thread CMakeLists.txt
Comment thread src/celeritas/track/TrackInitData.hh
Comment thread src/corecel/random/engine/InitializeRngState.hh Outdated
Comment thread src/corecel/random/data/RanluxppRngData.hh Outdated
@sethrj

sethrj commented Feb 26, 2026

Copy link
Copy Markdown
Member

@davidsgr not sure if you saw the feedback above!

@davidsgr

Copy link
Copy Markdown
Contributor Author

@davidsgr not sure if you saw the feedback above!

I did. Sorry for the delay, I've been in a conference/meeting all week. I'm planning on getting hopefully today or tomorrow.

@davidsgr

davidsgr commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

@sethrj I think this is ready for another look.

@sethrj
sethrj enabled auto-merge (squash) March 3, 2026 13:26
@sethrj
sethrj merged commit 978b263 into celeritas-project:develop Mar 3, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Software engineering infrastructure (corecel) enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants