Repository navigation
fix(blob): treat missing assets as uploadable - #2
Merged
Merged
Conversation
Use the SDK BlobNotFoundError class when checking for existing assets so a fresh publication proceeds to upload. Add regression coverage for the missing-asset path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first real publication run stopped when checking for an existing Blob asset. With the installed
@vercel/blobversion,BlobNotFoundErrorinherits the nameError, so the uploader did not recognize a missing asset and never reached the upload call.Fix
BlobNotFoundErrorclass directlyVerification
npm run checkpassed: formatting, lint, typecheck, 28 tests, and note validation