Set get notification to use DB reader#2910
Open
jzbahrai wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Routes get_notification_with_personalisation DB reads through the configured reader bind (instead of the default session), aligning this endpoint with the project’s read/write routing approach.
Changes:
- Updated
get_notification_with_personalisationto query viadb.on_reader().query(...). - Added a unit test that asserts the DAO function uses the reader bind.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/dao/notifications_dao.py | Switches get_notification_with_personalisation to use the DB reader bind for the query. |
| tests/app/dao/notification_dao/test_notification_dao.py | Adds a test that verifies the reader bind is used by the DAO function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
336
to
+342
| def get_notification_with_personalisation(service_id, notification_id, key_type): | ||
| filter_dict = {"service_id": service_id, "id": notification_id} | ||
| if key_type: | ||
| filter_dict["key_type"] = key_type | ||
|
|
||
| try: | ||
| return Notification.query.filter_by(**filter_dict).options(joinedload("template")).one() | ||
| return db.on_reader().query(Notification).filter_by(**filter_dict).options(joinedload("template")).one() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
TODO: 1-3 sentence description of the changed you're proposing.
Related Issues | Cartes liées
Test instructions | Instructions pour tester la modification
TODO: Fill in test instructions for the reviewer.
Release Instructions | Instructions pour le déploiement
None.
Reviewer checklist | Liste de vérification du réviseur