Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

A11y improvements for file upload#206

Open
dsamojlenko wants to merge 10 commits into
masterfrom
a11y_fix_for_file_upload
Open

A11y improvements for file upload#206
dsamojlenko wants to merge 10 commits into
masterfrom
a11y_fix_for_file_upload

Conversation

@dsamojlenko

@dsamojlenko dsamojlenko commented Mar 19, 2020

Copy link
Copy Markdown
Member

What this does

Improves a11y of the File Uploader:

  • Makes the upload input element visible to screen readers (hidden >> sr-only)
  • Adds visual focus to the upload button (using focus-within on parent div)
  • Makes the delete links visible to screen readers (span >> a)
  • Sets focus back to the upload button after deleting a file

TODO

  • Need to run this by Julianna
  • Need to roll this out to the Supporting Documents component which has similar issues

@dsamojlenko dsamojlenko requested a review from a team as a code owner March 19, 2020 15:24
@dsamojlenko dsamojlenko changed the title A11y fix for file upload A11y improvements for file upload Mar 19, 2020
@dsamojlenko dsamojlenko temporarily deployed to cppd-medical-a11y-fix-f-ibexfh March 19, 2020 16:56 Inactive

@CalvinRodo CalvinRodo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine just missing the following features:

  • Upload button is missing hover styles.
  • Upload button doesn't show up in tab order.
  • Upload button doesn't get highlighting when it's selected.

@dsamojlenko dsamojlenko temporarily deployed to cppd-medical-a11y-fix-f-ibexfh March 19, 2020 17:21 Inactive
@dsamojlenko dsamojlenko temporarily deployed to cppd-medical-a11y-fix-f-ibexfh March 19, 2020 17:44 Inactive
@dsamojlenko dsamojlenko temporarily deployed to cppd-medical-a11y-fix-f-ibexfh March 20, 2020 17:48 Inactive
@dsamojlenko dsamojlenko temporarily deployed to cppd-medical-a11y-fix-f-ibexfh March 20, 2020 19:27 Inactive
@CalvinRodo CalvinRodo self-requested a review March 20, 2020 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants