This repository was archived by the owner on Sep 20, 2021. It is now read-only.
A11y improvements for file upload#206
Open
dsamojlenko wants to merge 10 commits into
Open
Conversation
CalvinRodo
previously requested changes
Mar 19, 2020
CalvinRodo
left a comment
Member
There was a problem hiding this comment.
Code looks fine just missing the following features:
- Upload button is missing hover styles.
- Upload button doesn't show up in tab order.
- Upload button doesn't get highlighting when it's selected.
CalvinRodo
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Improves a11y of the File Uploader:
TODO