[HOLD] HCP declaration view for processing staff

[jeffmaher]

Details

Implementation of this Trello card.

Some other, but related, things to call out:

• Added the HCP info summary view to the processing staff view of the medical report. This was needed to provide the link to navigate to the view covered in this feature.
• Grouped some of the processing staff Sails policies together since they're not used in two places
• Change MedicalReport.practitionerType to a string value
• The HCP's timezone offset is gotten from their browser at submission time, but is checked for validity between -12 and +14 hours, so that no one can rig the eligibility date via tricking the submission time. (i.e. setting the timezone offset manually to +100000, etc.)
• On the processing staff view of the declaration, the signed by date/time is the date/time local to the HCP/signatory, not to the processing staff member viewing it.
• IP address is collected from the HCP's submission request (i.e. when they sign the declaration).

Instructions

Do this twice, once for each type of declaration signature (i.e. drawn vs. typed):

1. Applicant: Fill out personal, consent, get a code
2. HCP: Login w/ code and birthdate, and fill out all sections
3. Processing Staff: Go to /en/sessions and login (test@user.com, secret)
4. Processing Staff: Go to your submission
5. Processing Staff: View the HCP summary
6. Processing Staff: View the HCP declaration

Notes

• Known bug (not introduced in this branch, exists in master): After declaration is submitted, data is saved and then the HCP is kicked to the /en/medical-practitioner page instead of going to the view and print page.

[lgtm-com]

This pull request introduces 1 alert when merging c236bb2 into 52f7dd7 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request introduces 1 alert when merging 97eaab1 into 52f7dd7 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[jeffmaher]

Ready for design and policy review

[kylejones-ESDC]

1. When MP chooses RN in isolated region or NP the MA view of the declaration page still says "Dr." before the MP's name. It should not say "Dr." for these two groups.
2. Missing units of measure for H&W on MA display.
   Otherwise it looks alright.

[michellengaiCDS]

Going through the HCP medical report, when I hit "Type it" instead of "Draw it", the Draw it instructions still displays above the Type it ones, although the box disappears.

[michellengaiCDS]

Otherwise viewing of the consent seems to work.

[jeffmaher]

1. When MP chooses RN in isolated region or NP the MA view of the declaration page still says "Dr." before the MP's name.  It should not say "Dr." for these two groups.

2. Missing units of measure for H&W on MA display.
   Otherwise it looks alright.

@kylejones-ESDC : Good catches! Will fix number 1 and post back when ready. Can you file a bug for H&W for the processing staff display?

[jeffmaher]

Going through the HCP medical report, when I hit "Type it" instead of "Draw it", the Draw it instructions still displays above the Type it ones, although the box disappears.

@michellengaiCDS : Nice find! Could you file a bug for that since it's a different scope?

[kylejones-ESDC]

Will do.

…

On Wed, Feb 26, 2020 at 11:13 AM Jeff Maher ***@***.***> wrote: 1. When MP chooses RN in isolated region or NP the MA view of the declaration page still says "Dr." before the MP's name. It should not say "Dr." for these two groups. 2. Missing units of measure for H&W on MA display. Otherwise it looks alright. @kylejones-ESDC <https://github.com/kylejones-ESDC> : Good catches! Will fix number 1 and post back when ready. Can you file a bug for H&W for the processing staff display? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159?email_source=notifications&email_token=ANVT7KUX6DD3SPLNBKMPUKDRE2IJXA5CNFSM4KZG7FJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENA3NUI#issuecomment-591509201>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANVT7KXCSI3CZILSNAMRWC3RE2IJXANCNFSM4KZG7FJA> .

[michellengaiCDS]

Yes! Thanks.

[CalvinRodo]

@jeffmaher Since this adds new pages and we have Cypress tests setup can we include some test coverage for this.

Alternatively I'm okay with a task added to Trello to cover that case.

[jeffmaher]

@kylejones-ESDC : Fixed issue with the display of the title Dr.. It now only shows for the choice of CCFP or Other Physician Specialty. Ready for re-review.

@CalvinRodo : Haven't gotten to Cypress tests yet, so not quite ready for dev review yet.

[kylejones-ESDC]

Looks good. It would still be useful for the MA to know what type of HCP filled out the MR. In Figma the designation (GP, FD, NP, RN) is displayed in brackets after the practitioner's name. That look or something similar would be nice to have. Noting that it does provide the designation when you go to view the declaration and signature page so it's not a big deal.

[dsamojlenko]

I chased down the cause of that known bug and left a comment on the trello ticket

[jeffmaher]

@CalvinRodo : Chatted with @dsamojlenko and he suggested we merge this, and add a task for tests on the processing staff side since this would require lots of new Cypress code just to get to this page. With that said, I don't want this to be our model forever, but makes sense for now. Let me know if you approve or not.

[jeffmaher]

This is blocked on the translation file diff, which looks really hard. Added a Trello card to unblock, but can't merge before then.