This repository was archived by the owner on Sep 20, 2021. It is now read-only.
Added a flags to enable azure services.#155
Merged
Merged
Conversation
CalvinRodo
changed the title
var-kyle
reviewed
Feb 19, 2020
Member
|
See #158 for production builds |
|
This pull request introduces 1 alert when merging ebe1272 into 9fa1359 - view on LGTM.com new alerts:
|
Getting latest version of lodash Output environment variables when logging at debug level
CalvinRodo
changed the title
Member
Author
|
I'll update the description later. |
dsamojlenko
suggested changes
Feb 25, 2020
Comment on lines
+66
to
+69
| options: { | ||
| logging: 'verbose', | ||
| dialectOptions: generateDialectOptions(), | ||
| } |
Member
There was a problem hiding this comment.
Just noting that we should come back once we are able to run production builds and remove this conditional stuff and move it into config/env/production.js
Contributor
There was a problem hiding this comment.
Added a todo, but this will likely get resolved in #158
Comment on lines
+12
to
+19
| const featureFlags = require('../api/utils/FeatureFlags'); | ||
| function generateTls() { | ||
| if (featureFlags.isEnabled('FEATURE_REDIS_SSL')) { | ||
| return { }; | ||
| } | ||
| return undefined; | ||
| } | ||
|
|
dsamojlenko
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note:
This is a bit janky ideally we would use a special production.js configuration for this, and wouldn't use the default connection in the datastore.js that is mainly meant for local stuff only. This will change soon as we have prod builds working
To Test:
Also adds the latest version of Lodash