Upgrade jackson, json-smart, and netty dependency versions#1993
Upgrade jackson, json-smart, and netty dependency versions#1993sidhdirenge wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates subproject commits for azure and kafka-plugins, upgrades the parquet-avro dependency in format-parquet/pom.xml, and adds json-smart to the parent pom.xml dependency management. Feedback recommends managing the parquet-avro and json-smart versions via properties in the parent POM rather than hardcoding them, and points out that the Jackson and Netty dependency versions should also be updated in the parent POM to prevent potential version mismatches.
| <dependency> | ||
| <groupId>net.minidev</groupId> | ||
| <artifactId>json-smart</artifactId> | ||
| <version>2.4.11</version> | ||
| </dependency> |
There was a problem hiding this comment.
The pull request title indicates an upgrade for Jackson and Netty dependency versions, but the corresponding properties <jackson.databind.version> and <netty.version> in the parent pom.xml have not been updated.
If these properties are not updated in the parent POM, modules inheriting from it (such as format-parquet or other core modules) will continue to use the older versions, potentially leading to version mismatches or classpath issues with the upgraded submodules (azure, kafka-plugins).
Additionally, please consider defining a property for the json-smart version (e.g., ${json-smart.version}) in the <properties> section of the parent POM to keep it consistent with other dependency versions.
| <dependency> | |
| <groupId>net.minidev</groupId> | |
| <artifactId>json-smart</artifactId> | |
| <version>2.4.11</version> | |
| </dependency> | |
| <dependency> | |
| <groupId>net.minidev</groupId> | |
| <artifactId>json-smart</artifactId> | |
| <version>${json-smart.version}</version> | |
| </dependency> |
| <groupId>org.apache.parquet</groupId> | ||
| <artifactId>parquet-avro</artifactId> | ||
| <version>1.12.0</version> | ||
| <version>1.12.3</version> |
There was a problem hiding this comment.
Instead of hardcoding the version 1.12.3 directly in the child POM, it is recommended to manage this version in the parent pom.xml (either via <dependencyManagement> or by defining a <parquet.version> property in the parent POM). This ensures consistency across all modules and aligns with how other dependencies in this project are managed.
| <version>1.12.3</version> | |
| <version>${parquet.version}</version> |
4d6eaef to
7f1969c
Compare
…, CVE-2021-27568, CVE-2015-2156 - Root pom.xml: Add json-smart override to 2.4.11 - format-parquet/pom.xml: Bump parquet-avro to 1.12.3 - kafka-plugins: Bump jackson.version to 2.13.4.2 - azure: Override netty version to 3.9.9.Final in adls-plugins
7f1969c to
ebf541b
Compare
No description provided.