🐛 Fixed I/O cell handling in assign_cell_type

[Drewniok]

Description

This PR addresses a bug in the assign_cell_type function. Previously, when assigning a new cell type to an input or output cell, the corresponding updates to the inputs and outputs were not correctly applied. This issue has now been resolved, ensuring that inputs and outputs are properly updated when a cell type is reassigned.

Checklist:

• The pull request only contains commits that are related to it.
• I have added appropriate tests and documentation.
• I have added a changelog entry.
• I have created/adjusted the Python bindings for any new or updated functionality.
• I have made sure that all CI jobs on GitHub pass.
• The pull request introduces no new warnings and follows the project's style guidelines.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[codecov]

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.20%. Comparing base (50e81f5) to head (32c18b1).
⚠️ Report is 59 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/algorithms/physical_design/design_sidb_gates.hpp	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   98.21%   98.20%   -0.01%     
==========================================
  Files         255      255              
  Lines       42897    42918      +21     
  Branches     2014     2015       +1     
==========================================
+ Hits        42130    42149      +19     
- Misses        767      769       +2     

Files with missing lines	Coverage Δ
include/fiction/layouts/cell_level_layout.hpp	100.00% <100.00%> (ø)
...tion/technology/is_sidb_gate_design_impossible.hpp	100.00% <100.00%> (ø)
...t/algorithms/physical_design/design_sidb_gates.cpp	100.00% <100.00%> (ø)
test/layouts/cell_level_layout.cpp	100.00% <100.00%> (ø)
...n/algorithms/physical_design/design_sidb_gates.hpp	97.10% <90.90%> (-0.79%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e494d...32c18b1. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[marcelwa]

@Drewniok could you make sure that the tests hit 95% of added lines? Then, I will have a look.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[wlambooy]

Hi Jan, thanks a lot for the continued development here! I added some quite detailed comments of concerns that arose while looking into it, I'm looking forward to hear if you agree! Let's strive for simplicity and longevity in fiction! 💪

[Drewniok]

Hi Jan, thanks a lot for the continued development here! I added some quite detailed comments of concerns that arose while looking into it, I'm looking forward to hear if you agree! Let's strive for simplicity and longevity in fiction! 💪

Many thanks, @wlambooy! I will address your comments asap!

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[Drewniok]

I would be happy to hear your feedback on this PR, @marcelwa. Many thanks! 🙏

[marcelwa]

Thank you @Drewniok for the fix and @wlambooy for the initial review. In my opinion, you did a great job, as I don't spot anything to comment on.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[wlambooy]

Thanks for looking into my comments, I see nothing further to comment on. Thanks a lot!