Add gallery image starring and starred images gallery#3549
Open
Mundisoft wants to merge 1 commit into
Open
Conversation
Author
|
I’d appreciate feedback on the direction of this starred-images feature. If this feature is interesting, I’m happy to also implement one or both of these additions as part of this PR:
Another possible direction (instead of link-based stars that can become dead) is to store starred media locally via IndexedDB. If that’s of interest, I’m happy to look into it. Implementation note: the current starred list uses the existing storage abstraction, which may be shared between normal and private windows depending on environment. If this is a concern, I can investigate a localStorage-scoped approach for starred images instead of using the current storage abstraction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starredGalleryImages)Notes