Skip to content

fix: make DynamoDB client properties lazy to fix intermittent host.docker.internal 404 errors #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staktrace merged 1 commit into from
Mar 23, 2026
Merged

fix: make DynamoDB client properties lazy to fix intermittent host.docker.internal 404 errors #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...g-internal/src/main/kotlin/app/cash/tempest/testing/internal/DefaultTestDynamoDbClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,12 @@ class DefaultTestDynamoDbClient(
override val tables: List<TestTable>,
private val port: Int,
) : AbstractIdleService(), TestDynamoDbClient {
// TODO: Is there a better way of doing this than making a network connection?
// Lazy so that hostName is resolved after the DynamoDB Local server is started,
// not at construction time when the placeholder ServerSocket is still holding the port.
private val hostName by lazy { hostName(port) }

override val dynamoDb = buildDynamoDb(hostName, port)
override val dynamoDbStreams = buildDynamoDbStreams(hostName, port)
override val dynamoDb by lazy { buildDynamoDb(hostName, port) }
override val dynamoDbStreams by lazy { buildDynamoDbStreams(hostName, port) }

override fun startUp() {
reset()
Expand Down
11 changes: 6 additions & 5 deletions ...-internal/src/main/kotlin/app/cash/tempest2/testing/internal/DefaultTestDynamoDbClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ class DefaultTestDynamoDbClient(
override val tables: List<TestTable>,
private val port: Int,
) : AbstractIdleService(), TestDynamoDbClient {
// TODO: Is there a better way of doing this than making a network connection?
// Lazy so that hostName is resolved after the DynamoDB Local server is started,
// not at construction time when the placeholder ServerSocket is still holding the port.
private val hostName by lazy { hostName(port) }

override val dynamoDb = buildDynamoDb(hostName, port)
override val asyncDynamoDb = buildAsyncDynamoDb(hostName, port)
override val dynamoDbStreams = buildDynamoDbStreams(hostName, port)
override val asyncDynamoDbStreams = buildAsyncDynamoDbStreams(hostName, port)
override val dynamoDb by lazy { buildDynamoDb(hostName, port) }
override val asyncDynamoDb by lazy { buildAsyncDynamoDb(hostName, port) }
override val dynamoDbStreams by lazy { buildDynamoDbStreams(hostName, port) }
override val asyncDynamoDbStreams by lazy { buildAsyncDynamoDbStreams(hostName, port) }

override fun startUp() {
reset()
Expand Down
Loading